From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Bart Van Assche <bvanassche@acm.org>, <dsterba@suse.cz>,
<bhelgaas@google.com>, "tglx@linutronix.de" <tglx@linutronix.de>,
"Alexander Duyck" <alexander.h.duyck@linux.intel.com>,
<sakari.ailus@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
David Sterba <dsterba@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] async: Let kfree() out of the critical area of the lock
Date: Fri, 27 Sep 2019 09:00:41 +0800 [thread overview]
Message-ID: <cadede43-776e-449d-c6e5-c7f9c2c1acf2@huawei.com> (raw)
In-Reply-To: <e339db78-413c-446a-8e07-40e6e1ad4a31@acm.org>
On 2019/9/26 23:18, Bart Van Assche wrote:
> On 9/26/19 4:06 AM, David Sterba wrote:
>> On Thu, Sep 26, 2019 at 03:58:36PM +0800, Yunfeng Ye wrote:
>>> The async_lock is big global lock, I think it's good to put kfree() outside
>>> to keep the critical area as short as possible.
>>
>> Agreed, kfree is not always cheap. We had patches in btrfs moving kfree
>> out of critical section(s) after causing softlockups due to increased lock
>> contention.
>
> The above would be a great addition for the commit description. Anyway:
>
ok, I will update the description, thanks.
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
> .
>
prev parent reply other threads:[~2019-09-27 1:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:52 Yunfeng Ye
2019-09-25 13:38 ` gregkh
2019-09-25 13:45 ` Yunfeng Ye
2019-09-25 15:20 ` Alexander Duyck
2019-09-26 7:58 ` Yunfeng Ye
2019-09-26 11:06 ` David Sterba
2019-09-26 15:18 ` Bart Van Assche
2019-09-27 1:00 ` Yunfeng Ye [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cadede43-776e-449d-c6e5-c7f9c2c1acf2@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bvanassche@acm.org \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®