From: Arnd Bergmann <arnd@arndb.de>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@nxp.com>, Felipe Balbi <balbi@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON
Date: Tue, 13 Sep 2016 09:36:39 +0200 [thread overview]
Message-ID: <21754633.f6gFxZW7VA@wuerfel> (raw)
In-Reply-To: <20160913071942.GC30425@b29397-desktop>
On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote:
>
> I just see below Kconfig entry at the same Kconfig
> (drivers/usb/Kconfig), and forget your changes.
>
> config USB_LED_TRIG
> bool "USB LED Triggers"
> depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> help
> This option adds LED triggers for USB host and/or gadget activity.
>
> Say Y here if you are working on a system with led-class supported
> LEDs and you want to use them as activity indicators for USB host or
> gadget.
>
> Just grep it, some Kconfig still uses depends on for USB_COMMON, let me
> change it together.
>
I suspect this one above should instead depend on "USB_SUPPORT".
Arnd
next prev parent reply other threads:[~2016-09-13 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 15:36 Arnd Bergmann
2016-09-13 1:48 ` Peter Chen
2016-09-13 7:04 ` Arnd Bergmann
2016-09-13 7:19 ` Peter Chen
2016-09-13 7:36 ` Arnd Bergmann [this message]
2016-09-13 8:50 ` Peter Chen
2016-09-13 10:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21754633.f6gFxZW7VA@wuerfel \
--to=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hzpeterchen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®