From: Peter Chen <hzpeterchen@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@nxp.com>, Felipe Balbi <balbi@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON
Date: Tue, 13 Sep 2016 09:48:55 +0800 [thread overview]
Message-ID: <20160913014855.GE25182@b29397-desktop> (raw)
In-Reply-To: <20160912153649.3163096-1-arnd@arndb.de>
On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote:
> Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file
> means that we can enable it without any of the other USB support,
> leading to a build error because Kbuild never enters the
> drivers/usb/common/ directory without CONFIG_USB_COMMON:
>
> ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined!
> ERROR: "__ulpi_register_driver" [drivers/phy/phy-tusb1210.ko] undefined!
> ERROR: "ulpi_write" [drivers/phy/phy-tusb1210.ko] undefined!
>
Thanks, Arnd. I have submitted the fix.
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=6406c3d226374c28d452b11db3b5ac241ce26191
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-09-13 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 15:36 Arnd Bergmann
2016-09-13 1:48 ` Peter Chen [this message]
2016-09-13 7:04 ` Arnd Bergmann
2016-09-13 7:19 ` Peter Chen
2016-09-13 7:36 ` Arnd Bergmann
2016-09-13 8:50 ` Peter Chen
2016-09-13 10:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913014855.GE25182@b29397-desktop \
--to=hzpeterchen@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®