From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Al Stone <al.stone@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v2 1/2] ACPI / tables: simplify acpi_parse_entries
Date: Sat, 26 Sep 2015 02:27:43 +0200 [thread overview]
Message-ID: <2184252.JT4i34L2sb@vostro.rjw.lan> (raw)
In-Reply-To: <1442408287-10410-1-git-send-email-sudeep.holla@arm.com>
On Wednesday, September 16, 2015 01:58:06 PM Sudeep Holla wrote:
> acpi_parse_entries passes the table end pointer to the sub-table entry
> handler. acpi_parse_entries itself could validate the end of an entry
> against the table end using the length in the sub-table entry.
>
> This patch adds the validation of the sub-table entry end using the
> length field.This will help to eliminate the need to pass the table end
> to the handlers.
>
> It also moves the check for zero length entry early so that execution of
> the handler can be avoided.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> ---
> drivers/acpi/tables.c | 31 +++++++++++++++----------------
> 1 file changed, 15 insertions(+), 16 deletions(-)
>
> Hi Rafael,
>
> As I mentioned earlier, this needs to be applied after Al's MADT changes
> are merged. You might get simple conflicts in acpi_parse_entries.
This needs to be rebased on top of some patches in my linux-next branch.
It probably is better to rebase it on top of my bleeding-edge branch that
contains the Al's patches already, though.
Thanks,
Rafael
next prev parent reply other threads:[~2015-09-25 23:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442243686-15845-1-git-send-email-sudeep.holla@arm.com>
2015-09-16 12:58 ` Sudeep Holla
2015-09-16 12:58 ` [PATCH v2 2/2] ACPI / tables : remove unused table_end parameter to acpi_tbl_entry_handler Sudeep Holla
2015-09-26 0:27 ` Rafael J. Wysocki [this message]
2015-09-28 10:11 ` [PATCH v2 1/2] ACPI / tables: simplify acpi_parse_entries Sudeep Holla
2015-09-28 13:50 ` Rafael J. Wysocki
2015-09-28 13:37 ` Sudeep Holla
2015-09-28 19:39 ` Al Stone
2015-09-28 19:46 ` Rafael J. Wysocki
2015-10-01 15:11 ` [PATCH v3 " Sudeep Holla
2015-10-01 15:11 ` [PATCH v3 2/2] ACPI / tables : remove unused table_end parameter to acpi_tbl_entry_handler Sudeep Holla
2015-10-15 15:44 ` [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries Sudeep Holla
2015-10-15 15:57 ` Al Stone
2015-10-15 21:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2184252.JT4i34L2sb@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=al.stone@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®