From: Tao Chen <chen.dylane@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Song Liu <song@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Martin KaFai Lau <martin.lau@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
Hao Luo <haoluo@google.com>, bpf <bpf@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT
Date: Tue, 7 Nov 2023 00:13:06 +0800 [thread overview]
Message-ID: <21a93447-6830-4884-b488-cbac38df1b96@gmail.com> (raw)
In-Reply-To: <CA+92Ff+ZW5wu3mZFs--nxcyJyc7YxEhP-yuL-BEsWzVChR9Jdg@mail.gmail.com>
Hi, Alexei, the delete element api of stackmap return E2BIG when the key
size beyond the buckets size, so i try to keep the same approach. Maybe
it's not necessary, anyway, thanks for your reply.
在 2023/11/6 下午11:59, Tao Chen 写道:
>
>
> ---------- Forwarded message ---------
> 发件人： *Alexei Starovoitov* <alexei.starovoitov@gmail.com
> <mailto:alexei.starovoitov@gmail.com>>
> Date: 2023年11月5日周日 04:54
> Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT
> To: Tao Chen <chen.dylane@gmail.com <mailto:chen.dylane@gmail.com>>
> Cc: Song Liu <song@kernel.org <mailto:song@kernel.org>>, Jiri Olsa
> <jolsa@kernel.org <mailto:jolsa@kernel.org>>, Alexei Starovoitov
> <ast@kernel.org <mailto:ast@kernel.org>>, Daniel Borkmann
> <daniel@iogearbox.net <mailto:daniel@iogearbox.net>>, Andrii Nakryiko
> <andrii@kernel.org <mailto:andrii@kernel.org>>, Yonghong Song
> <yonghong.song@linux.dev <mailto:yonghong.song@linux.dev>>, Martin KaFai
> Lau <martin.lau@linux.dev <mailto:martin.lau@linux.dev>>, John Fastabend
> <john.fastabend@gmail.com <mailto:john.fastabend@gmail.com>>, Hao Luo
> <haoluo@google.com <mailto:haoluo@google.com>>, bpf <bpf@vger.kernel.org
> <mailto:bpf@vger.kernel.org>>, LKML <linux-kernel@vger.kernel.org
> <mailto:linux-kernel@vger.kernel.org>>
>
>
> On Fri, Nov 3, 2023 at 7:44 PM Tao Chen <chen.dylane@gmail.com
> <mailto:chen.dylane@gmail.com>> wrote:
> >
> > Use E2BIG instead of ENOENT when the key size beyond the buckets size,
> > it seems more meaningful.
>
> seems more meaningful?
> Sorry. That's hardly a reason to break someone's code.
prev parent reply other threads:[~2023-11-06 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 2:44 Tao Chen
2023-11-04 20:54 ` Alexei Starovoitov
[not found] ` <CA+92Ff+ZW5wu3mZFs--nxcyJyc7YxEhP-yuL-BEsWzVChR9Jdg@mail.gmail.com>
2023-11-06 16:13 ` Tao Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a93447-6830-4884-b488-cbac38df1b96@gmail.com \
--to=chen.dylane@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®