mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Andi Shyti <andi.shyti@kernel.org>,
	Kathiravan Thirumoorthy
	<kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: Viken Dadhaniya <quic_vdadhani@quicinc.com>,
	Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	<linux-i2c@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <stable@kernel.org>
Subject: Re: [PATCH] i2c: qcom-geni: fix I2C frequency table to achieve accurate bus rates
Date: Fri, 16 May 2025 00:23:46 +0530	[thread overview]
Message-ID: <21ae6a2d-c8dd-4064-a851-6a10649ddf90@quicinc.com> (raw)
In-Reply-To: <y4t3xshxsbrx6xqkxroai3vixjacskco5baaoip2apzjkehjxx@ah6wxu2gy24g>

Thanks Andi !

On 5/14/2025 9:04 PM, Andi Shyti wrote:

[...]
>>   /* source_clock = 32 MHz */
>>   static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz[] = {
>> -	{ I2C_MAX_STANDARD_MODE_FREQ, 8, 14, 18, 40 },
>> -	{ I2C_MAX_FAST_MODE_FREQ, 4,  3, 11, 20 },
>> -	{ I2C_MAX_FAST_MODE_PLUS_FREQ, 2, 3,  6, 15 },
>> +	{ I2C_MAX_STANDARD_MODE_FREQ, 8, 14, 18, 38 },
>> +	{ I2C_MAX_FAST_MODE_FREQ, 4,  3, 9, 19 },
>> +	{ I2C_MAX_FAST_MODE_PLUS_FREQ, 2, 3, 5, 15 },
> 
> argh!
> 
> Can someone from Qualcomm look at this fix? Mukesh, Viken?
Yes, I am reviewing internally and verifying the same with latest 
Guidance and updates. Let me update on this once reviewed.
> 
> Thanks,
> Andi
> 
>>   	{}
>>   };
>>   
>>
>> ---
>> base-commit: edef457004774e598fc4c1b7d1d4f0bcd9d0bb30
>> change-id: 20250513-i2c-bus-freq-ac46343869a4
>>
>> Best regards,
>> -- 
>> Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>


  reply	other threads:[~2025-05-15 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 11:08 Kathiravan Thirumoorthy
2025-05-14 15:34 ` Andi Shyti
2025-05-15 18:53   ` Mukesh Kumar Savaliya [this message]
2025-05-16  8:46     ` Andi Shyti
2025-05-21  6:25       ` Mukesh Kumar Savaliya
2025-07-29 22:42 ` Andi Shyti
2025-07-30 10:21   ` Kathiravan Thirumoorthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21ae6a2d-c8dd-4064-a851-6a10649ddf90@quicinc.com \
    --to=quic_msavaliy@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_mmanikan@quicinc.com \
    --cc=quic_vdadhani@quicinc.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®