From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
"Viken Dadhaniya" <quic_vdadhani@quicinc.com>,
Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@kernel.org>
Subject: Re: [PATCH] i2c: qcom-geni: fix I2C frequency table to achieve accurate bus rates
Date: Wed, 21 May 2025 11:55:14 +0530 [thread overview]
Message-ID: <3f024bd8-3388-4984-a962-531e3fe88c6a@quicinc.com> (raw)
In-Reply-To: <sdhflgjsnvn7l2pix7e5k5yijycy53tmpg4w7722icp6na5rcx@kec7ra7tc4xc>
Looks good to me, Thanks Kathiravan, Andi !
On 5/16/2025 2:16 PM, Andi Shyti wrote:
> Hi Mukesh,
>
> On Fri, May 16, 2025 at 12:23:46AM +0530, Mukesh Kumar Savaliya wrote:
>>>> /* source_clock = 32 MHz */
>>>> static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz[] = {
>>>> - { I2C_MAX_STANDARD_MODE_FREQ, 8, 14, 18, 40 },
>>>> - { I2C_MAX_FAST_MODE_FREQ, 4, 3, 11, 20 },
>>>> - { I2C_MAX_FAST_MODE_PLUS_FREQ, 2, 3, 6, 15 },
>>>> + { I2C_MAX_STANDARD_MODE_FREQ, 8, 14, 18, 38 },
>>>> + { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 19 },
>>>> + { I2C_MAX_FAST_MODE_PLUS_FREQ, 2, 3, 5, 15 },
>>>
>>> argh!
>>>
>>> Can someone from Qualcomm look at this fix? Mukesh, Viken?
>> Yes, I am reviewing internally and verifying the same with latest Guidance
>> and updates. Let me update on this once reviewed.
>
> thanks a lot! It's very much appreciated!
>
Reviewed-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> Andi
next prev parent reply other threads:[~2025-05-21 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 11:08 Kathiravan Thirumoorthy
2025-05-14 15:34 ` Andi Shyti
2025-05-15 18:53 ` Mukesh Kumar Savaliya
2025-05-16 8:46 ` Andi Shyti
2025-05-21 6:25 ` Mukesh Kumar Savaliya [this message]
2025-07-29 22:42 ` Andi Shyti
2025-07-30 10:21 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f024bd8-3388-4984-a962-531e3fe88c6a@quicinc.com \
--to=quic_msavaliy@quicinc.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®