moving DRM header files

moving DRM header files

[Dave Airlie]

Hi,
I'd like to move the interface DRM header files (drm.h and *_drm.h)
somewhere more useful and also more "user-space" visible, (i.e. so
kernel-headers could start picking them up.)

I'm thinking include/linux/drm/
but include/linux would also be possible.

Any suggestions or ideas?

Dave.

Re: moving DRM header files

[Jon Smirl]

On 7/14/05, Dave Airlie <airlied@gmail.com> wrote:
> Hi,
> I'd like to move the interface DRM header files (drm.h and *_drm.h)
> somewhere more useful and also more "user-space" visible, (i.e. so
> kernel-headers could start picking them up.)
> 
> I'm thinking include/linux/drm/
> but include/linux would also be possible.
> 
> Any suggestions or ideas?

There is also include/linux/video

The duplicate defines need to get cleaned out of xf86drm.h or this is
going to get real confusing.

-- 
Jon Smirl
jonsmirl@gmail.com

Re: moving DRM header files

[Jon Smirl]

On 7/14/05, Dave Airlie <airlied@gmail.com> wrote:
> Hi,
> I'd like to move the interface DRM header files (drm.h and *_drm.h)
> somewhere more useful and also more "user-space" visible, (i.e. so
> kernel-headers could start picking them up.)
> 
> I'm thinking include/linux/drm/
> but include/linux would also be possible.
> 
> Any suggestions or ideas?

If you're in a mood to move things, how about moving drivers/char/drm
to drivers/video/drm.

-- 
Jon Smirl
jonsmirl@gmail.com

Re: moving DRM header files

[Dave Airlie]

> > I'm thinking include/linux/drm/
> > but include/linux would also be possible.
> >
> > Any suggestions or ideas?
> 
> If you're in a mood to move things, how about moving drivers/char/drm
> to drivers/video/drm.

But that has little point beyond aesthetics... moving the header files
is for a reason that I want them to start appearing in userspace
includeable places.. as part of the cleanup for libdrm..

Moving c files internally in the kernel provides no real benefit over
not moving them..

Dave.

Re: moving DRM header files

[Jon Smirl]

On 7/14/05, Dave Airlie <airlied@gmail.com> wrote:
> > > I'm thinking include/linux/drm/
> > > but include/linux would also be possible.
> > >
> > > Any suggestions or ideas?
> >
> > If you're in a mood to move things, how about moving drivers/char/drm
> > to drivers/video/drm.
> 
> But that has little point beyond aesthetics... moving the header files
> is for a reason that I want them to start appearing in userspace
> includeable places.. as part of the cleanup for libdrm..
> 
> Moving c files internally in the kernel provides no real benefit over
> not moving them..

When you start merging DRM and fbdev you will be able to use relative
paths that are closer together.  For example #include
"../char/drm/drmP.h" versus "#include "drm/drmP.h" for internal
headers.

DRM and fbdev need to be moved next to each other in kconfig too if
they start depending on each other. It if hard to figure out that a
video option might not be visible because the char/drm/option is not
turned on.

-- 
Jon Smirl
jonsmirl@gmail.com

Re: moving DRM header files

[Sam Ravnborg]

> 
> When you start merging DRM and fbdev you will be able to use relative
> paths that are closer together.  For example #include
> "../char/drm/drmP.h" versus "#include "drm/drmP.h" for internal
> headers.

No. Using relative include paths is not good. I will most probarly
not work with make O=.

	Sam

Re: moving DRM header files

[Arjan van de Ven]

On Thu, 2005-07-14 at 14:04 +1000, Dave Airlie wrote:
> Hi,
> I'd like to move the interface DRM header files (drm.h and *_drm.h)
> somewhere more useful and also more "user-space" visible, (i.e. so
> kernel-headers could start picking them up.)

I would suggest making ONE userspace visible header, and just put that
as include/linux/drm.h
and separate into that *ONLY* the userspace visible parts, and *NONE* of
the kernel visible parts, and keep the kernel parts in drivers/char/drm.