mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dave Airlie" <airlied@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Jeremy Katz" <katzj@redhat.com>,
	linux-kernel@vger.kernel.org, davej@redhat.com,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Map volume and brightness events on thinkpads
Date: Wed, 17 Oct 2007 06:32:55 +1000	[thread overview]
Message-ID: <21d7e9970710161332h7694579dp277ce774b0ce3956@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0710161208340.6887@woody.linux-foundation.org>

> > But it *is* a key press!
>
> To get somewhat back on track: volume and brightness (and similar - lid
> close etc) events clearly are keypresses.
>
> However, I would also argue that a keypress that is acted on by the
> firmware automatically is *different* from a keypress that hasn't been
> acted on: one is a "key was pressed *and* hardware did something
> automatically", and the other is just a "key was pressed" event.
>

We also have cases where userspace may have told ACPI to stop the
firmware acting on the keypress which may or may not be known to the
piece of the kernel dealing with keypresses... hence just pass the key
up to userspace and let it deal with it.

Dave.

  parent reply	other threads:[~2007-10-16 20:33 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15 20:45 Jeremy Katz
2007-10-15 21:07 ` Henrique de Moraes Holschuh
2007-10-15 21:27   ` Jeremy Katz
2007-10-16  9:12     ` Henrique de Moraes Holschuh
2007-10-15 21:43   ` Arjan van de Ven
2007-10-16  3:38   ` Jesse Barnes
2007-10-16  8:36     ` Henrique de Moraes Holschuh
2007-10-16  8:49       ` Jesse Barnes
2007-10-16  9:18         ` Henrique de Moraes Holschuh
2007-10-17  2:40           ` Jesse Barnes
2007-10-17  6:25             ` Henrique de Moraes Holschuh
2007-10-17  6:32               ` Jesse Barnes
2007-10-17  6:39                 ` Henrique de Moraes Holschuh
2007-10-16 13:00   ` Matthew Garrett
2007-10-16 14:11     ` Henrique de Moraes Holschuh
2007-10-16 14:21       ` Matthew Garrett
2007-10-16 14:31         ` Henrique de Moraes Holschuh
2007-10-16 14:40           ` Matthew Garrett
2007-10-16 16:56             ` Henrique de Moraes Holschuh
2007-10-16 18:46               ` Matthew Garrett
2007-10-16 19:14                 ` Linus Torvalds
2007-10-16 19:20                   ` Matthew Garrett
2007-10-16 20:02                     ` Henrique de Moraes Holschuh
2007-10-16 20:15                       ` Dmitry Torokhov
2007-10-16 20:12                   ` Dmitry Torokhov
2007-10-16 20:11                     ` Jeremy Katz
2007-10-16 20:19                       ` Dmitry Torokhov
2007-10-16 20:32                     ` Linus Torvalds
2007-10-17 15:57                       ` Dmitry Torokhov
2007-10-17 16:28                         ` Matthew Garrett
2007-10-17 17:35                           ` Henrique de Moraes Holschuh
2007-10-17 18:59                             ` Dmitry Torokhov
2007-10-17 20:42                               ` Henrique de Moraes Holschuh
2007-10-18 14:37                                 ` Dmitry Torokhov
2007-10-18 22:39                                   ` Henrique de Moraes Holschuh
2007-10-23 15:54                                     ` Dmitry Torokhov
2007-10-23 23:34                                       ` Henrique de Moraes Holschuh
2007-10-16 20:48                     ` Kok, Auke
2007-10-16 20:55                       ` Matthew Garrett
2007-10-16 21:18                         ` Dmitry Torokhov
2007-10-16 20:32                   ` Dave Airlie [this message]
2007-10-16 14:27       ` Dmitry Torokhov
2007-10-16 14:54         ` Matthew Garrett
2007-10-16 15:54           ` Dmitry Torokhov
2007-10-16 15:59             ` Matthew Garrett
2007-10-16 18:53 ` Matthew Garrett
2007-10-16 19:23   ` Renato S. Yamane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21d7e9970710161332h7694579dp277ce774b0ce3956@mail.gmail.com \
    --to=airlied@gmail.com \
    --cc=davej@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=katzj@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®