From: Lucas Stach <l.stach@pengutronix.de>
To: Sui Jingfeng <suijingfeng@loongson.cn>,
Sui Jingfeng <18949883232@163.com>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
etnaviv@lists.freedesktop.org
Subject: Re: [PATCH v10 01/11] drm/etnaviv: Add a dedicated function to register an irq handler
Date: Wed, 21 Jun 2023 12:16:26 +0200 [thread overview]
Message-ID: <21f781a548cef63312df56cb2265de9a7c9a0901.camel@pengutronix.de> (raw)
In-Reply-To: <52751b55-ce34-f3a8-b3c0-4858ad984622@loongson.cn>
Am Mittwoch, dem 21.06.2023 um 17:20 +0800 schrieb Sui Jingfeng:
> Hi,
>
> On 2023/6/21 17:07, Lucas Stach wrote:
> > Am Dienstag, dem 20.06.2023 um 17:47 +0800 schrieb Sui Jingfeng:
> > > From: Sui Jingfeng <suijingfeng@loongson.cn>
> > >
> > > Because getting IRQ from a device is platform-dependent, PCI devices have
> > > different methods for getting an IRQ. This patch is a preparation to extend
> > > this driver for supporting the PCI devices.
> > >
> > > Cc: Lucas Stach <l.stach@pengutronix.de>
> > > Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> > > ---
> > > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 32 +++++++++++++++++++--------
> > > 1 file changed, 23 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > > index de8c9894967c..a03e81337d8f 100644
> > > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > > @@ -1817,6 +1817,27 @@ static const struct of_device_id etnaviv_gpu_match[] = {
> > > };
> > > MODULE_DEVICE_TABLE(of, etnaviv_gpu_match);
> > >
> > > +static int etnaviv_gpu_register_irq(struct etnaviv_gpu *gpu, int irq)
> > > +{
> > > + struct device *dev = gpu->dev;
> > > + int err;
> > > +
> > > + if (irq < 0)
> > > + return irq;
> > > +
> > > + err = devm_request_irq(dev, irq, irq_handler, 0, dev_name(dev), gpu);
> > > + if (err) {
> > > + dev_err(dev, "failed to request irq %u: %d\n", irq, err);
> > > + return err;
> > > + }
> > > +
> > > + gpu->irq = irq;
> > > +
> > > + dev_info(dev, "irq(%d) handler registered\n", irq);
> > There is no reason to put this into the kernel log.
>
> I want to see the IRQ of the device when debugging,
>
> etnaviv actually print very less.
>
> This serve as a minimal signal to us the etnaviv_gpu_register_irq()
> function is successful at driver load time.
>
And debugging is a very different use-case than normal operation. If
it's needed at all, downgrade this to dev_dbg. This isn't interesting
information for a ordinary user of a system.
> > It's no different
> > than other resources to the driver and we don't log each one of those
> > either.
> >
> > In fact I don't see any reason for this change in the first place.
> > Effectively you are moving a single function call into a new function,
> > which doesn't seem like an improvement.
>
> This is to make the patch easy to review, each patch is only introduce a
> small function,
>
What I'm saying is that I don't see the need to introduce this function
at all. All you need to do is move platform_get_irq out into the
platform device code path. The devm_request_irq can stay where it is,
as the only difference between platform and PCI device is how the irq
number is retrieved from the platform.
Regards,
Lucas
> which is paving the way for we introducing the PCI device driver.
>
> Otherwise when we introducing the PCI device driver, the patch is looks
> ugly,
>
> It is difficult to review.
>
> > Regards,
> > Lucas
> >
> > > +
> > > + return 0;
> > > +}
> > > +
> > > static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
> > > {
> > > struct device *dev = &pdev->dev;
> > > @@ -1837,16 +1858,9 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
> > > return PTR_ERR(gpu->mmio);
> > >
> > > /* Get Interrupt: */
> > > - gpu->irq = platform_get_irq(pdev, 0);
> > > - if (gpu->irq < 0)
> > > - return gpu->irq;
> > > -
> > > - err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> > > - dev_name(gpu->dev), gpu);
> > > - if (err) {
> > > - dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
> > > + err = etnaviv_gpu_register_irq(gpu, platform_get_irq(pdev, 0));
> > > + if (err)
> > > return err;
> > > - }
> > >
> > > /* Get Clocks: */
> > > gpu->clk_reg = devm_clk_get_optional(&pdev->dev, "reg");
>
next prev parent reply other threads:[~2023-06-21 10:17 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:47 [PATCH v10 00/11] drm/etnaviv: Add pci device driver support Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 01/11] drm/etnaviv: Add a dedicated function to register an irq handler Sui Jingfeng
2023-06-21 9:07 ` Lucas Stach
2023-06-21 9:20 ` Sui Jingfeng
2023-06-21 10:16 ` Lucas Stach [this message]
2023-06-24 15:53 ` Sui Jingfeng
2023-06-26 10:57 ` Lucas Stach
2023-06-21 9:34 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 02/11] drm/etnaviv: Add a dedicated function to get various clocks Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 03/11] drm/etnaviv: Add dedicated functions to create and destroy platform device Sui Jingfeng
2023-06-21 9:15 ` Lucas Stach
2023-06-21 9:49 ` Sui Jingfeng
2023-06-21 10:23 ` Lucas Stach
2023-06-21 13:31 ` Sui Jingfeng
2023-06-21 14:00 ` Lucas Stach
2023-06-21 14:35 ` Sui Jingfeng
2023-06-21 14:38 ` Sui Jingfeng
2023-06-21 15:20 ` Lucas Stach
2023-06-21 16:12 ` Sui Jingfeng
2023-06-21 14:03 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 04/11] drm/etnaviv: Add helpers for private data construction and destruction Sui Jingfeng
2023-06-21 9:22 ` Lucas Stach
2023-06-21 12:31 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 05/11] drm/etnaviv: Allow bypass component framework Sui Jingfeng
2023-06-21 9:29 ` Lucas Stach
2023-06-21 13:04 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 06/11] drm/etnaviv: Add driver support for the PCI devices Sui Jingfeng
2023-06-21 9:39 ` Lucas Stach
2023-06-21 12:02 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device Sui Jingfeng
2023-06-21 10:00 ` Lucas Stach
2023-06-21 14:42 ` Sui Jingfeng
2023-06-21 14:44 ` Sui Jingfeng
2023-06-21 15:23 ` Lucas Stach
2023-06-21 15:41 ` Sui Jingfeng
2023-06-21 16:12 ` Lucas Stach
2023-06-21 16:33 ` Sui Jingfeng
2023-06-21 16:39 ` Sui Jingfeng
2023-06-21 14:45 ` Sui Jingfeng
2023-06-21 14:49 ` Sui Jingfeng
2023-06-21 15:00 ` Sui Jingfeng
2023-06-21 15:33 ` Lucas Stach
2023-06-21 15:54 ` Sui Jingfeng
2023-06-21 16:07 ` Lucas Stach
2023-06-21 17:31 ` Sui Jingfeng
2023-06-21 17:53 ` Lucas Stach
2023-06-25 4:04 ` Sui Jingfeng
2023-06-21 15:30 ` Sui Jingfeng
2023-06-21 15:58 ` Lucas Stach
2023-06-21 16:49 ` Sui Jingfeng
2023-06-21 17:21 ` Sui Jingfeng
2023-06-21 17:45 ` Lucas Stach
2023-06-24 16:10 ` Sui Jingfeng
2023-06-25 3:51 ` Sui Jingfeng
2023-06-26 11:08 ` Lucas Stach
2023-06-22 19:26 ` Sui Jingfeng
2023-06-23 11:52 ` Robin Murphy
2023-06-23 12:37 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 08/11] drm/etnaviv: Add a dedicated function to create the virtual master Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 09/11] drm/etnaviv: Clean up etnaviv_pdev_probe() function Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 10/11] drm/etnaviv: Keep the curly brace aligned Sui Jingfeng
2023-06-21 7:55 ` [PATCH v10 00/11] drm/etnaviv: Add pci device driver support Christian Gmeiner
2023-06-21 8:02 ` Sui Jingfeng
2023-06-21 8:05 ` Sui Jingfeng
-- strict thread matches above, loose matches on Subject: below --
2023-06-19 12:41 Sui Jingfeng
2023-06-19 12:41 ` [PATCH v10 01/11] drm/etnaviv: Add a dedicated function to register an irq handler Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f781a548cef63312df56cb2265de9a7c9a0901.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=18949883232@163.com \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=suijingfeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®