From: Sui Jingfeng <suijingfeng@loongson.cn>
To: Lucas Stach <l.stach@pengutronix.de>,
Sui Jingfeng <18949883232@163.com>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
etnaviv@lists.freedesktop.org
Subject: Re: [PATCH v10 03/11] drm/etnaviv: Add dedicated functions to create and destroy platform device
Date: Wed, 21 Jun 2023 22:03:14 +0800 [thread overview]
Message-ID: <74a45dff-a0ea-9d05-36e4-e5d6822dfcec@loongson.cn> (raw)
In-Reply-To: <6d287bbb1733814009dfeb7d48f08cb6f44dc56c.camel@pengutronix.de>
Hi,
On 2023/6/21 18:23, Lucas Stach wrote:
> That's right, but all you do with those indirections through the
> parameter list is move which of the functions is non-pure, in your case
> it's etnaviv_init/etnaviv_exit,
But there is a difference, etnaviv_init() and etnaviv_exit() is
impossible to be shared
there are only get called once when the module is loaded.
They can never be reused anymore, except here.
And etnaviv_init() and etnaviv_exit() don't have a choice.
But for etnaviv_create_platform_device() function,
there is a possibility to be reused in the future.
> with the indirection dropped it's
> etnaviv_create_platform_device/etnaviv_destroy_platform_device.
--
Jingfeng
next prev parent reply other threads:[~2023-06-21 14:03 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:47 [PATCH v10 00/11] drm/etnaviv: Add pci device driver support Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 01/11] drm/etnaviv: Add a dedicated function to register an irq handler Sui Jingfeng
2023-06-21 9:07 ` Lucas Stach
2023-06-21 9:20 ` Sui Jingfeng
2023-06-21 10:16 ` Lucas Stach
2023-06-24 15:53 ` Sui Jingfeng
2023-06-26 10:57 ` Lucas Stach
2023-06-21 9:34 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 02/11] drm/etnaviv: Add a dedicated function to get various clocks Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 03/11] drm/etnaviv: Add dedicated functions to create and destroy platform device Sui Jingfeng
2023-06-21 9:15 ` Lucas Stach
2023-06-21 9:49 ` Sui Jingfeng
2023-06-21 10:23 ` Lucas Stach
2023-06-21 13:31 ` Sui Jingfeng
2023-06-21 14:00 ` Lucas Stach
2023-06-21 14:35 ` Sui Jingfeng
2023-06-21 14:38 ` Sui Jingfeng
2023-06-21 15:20 ` Lucas Stach
2023-06-21 16:12 ` Sui Jingfeng
2023-06-21 14:03 ` Sui Jingfeng [this message]
2023-06-20 9:47 ` [PATCH v10 04/11] drm/etnaviv: Add helpers for private data construction and destruction Sui Jingfeng
2023-06-21 9:22 ` Lucas Stach
2023-06-21 12:31 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 05/11] drm/etnaviv: Allow bypass component framework Sui Jingfeng
2023-06-21 9:29 ` Lucas Stach
2023-06-21 13:04 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 06/11] drm/etnaviv: Add driver support for the PCI devices Sui Jingfeng
2023-06-21 9:39 ` Lucas Stach
2023-06-21 12:02 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device Sui Jingfeng
2023-06-21 10:00 ` Lucas Stach
2023-06-21 14:42 ` Sui Jingfeng
2023-06-21 14:44 ` Sui Jingfeng
2023-06-21 15:23 ` Lucas Stach
2023-06-21 15:41 ` Sui Jingfeng
2023-06-21 16:12 ` Lucas Stach
2023-06-21 16:33 ` Sui Jingfeng
2023-06-21 16:39 ` Sui Jingfeng
2023-06-21 14:45 ` Sui Jingfeng
2023-06-21 14:49 ` Sui Jingfeng
2023-06-21 15:00 ` Sui Jingfeng
2023-06-21 15:33 ` Lucas Stach
2023-06-21 15:54 ` Sui Jingfeng
2023-06-21 16:07 ` Lucas Stach
2023-06-21 17:31 ` Sui Jingfeng
2023-06-21 17:53 ` Lucas Stach
2023-06-25 4:04 ` Sui Jingfeng
2023-06-21 15:30 ` Sui Jingfeng
2023-06-21 15:58 ` Lucas Stach
2023-06-21 16:49 ` Sui Jingfeng
2023-06-21 17:21 ` Sui Jingfeng
2023-06-21 17:45 ` Lucas Stach
2023-06-24 16:10 ` Sui Jingfeng
2023-06-25 3:51 ` Sui Jingfeng
2023-06-26 11:08 ` Lucas Stach
2023-06-22 19:26 ` Sui Jingfeng
2023-06-23 11:52 ` Robin Murphy
2023-06-23 12:37 ` Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 08/11] drm/etnaviv: Add a dedicated function to create the virtual master Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 09/11] drm/etnaviv: Clean up etnaviv_pdev_probe() function Sui Jingfeng
2023-06-20 9:47 ` [PATCH v10 10/11] drm/etnaviv: Keep the curly brace aligned Sui Jingfeng
2023-06-21 7:55 ` [PATCH v10 00/11] drm/etnaviv: Add pci device driver support Christian Gmeiner
2023-06-21 8:02 ` Sui Jingfeng
2023-06-21 8:05 ` Sui Jingfeng
-- strict thread matches above, loose matches on Subject: below --
2023-06-19 12:41 Sui Jingfeng
2023-06-19 12:41 ` [PATCH v10 03/11] drm/etnaviv: Add dedicated functions to create and destroy platform device Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74a45dff-a0ea-9d05-36e4-e5d6822dfcec@loongson.cn \
--to=suijingfeng@loongson.cn \
--cc=18949883232@163.com \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®