From: Esko Mobius <echoowall@gmail.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
Shuah Khan <shuah@kernel.org>,
Thorsten Leemhuis <regressions@leemhuis.info>,
regressions@lists.linux.dev, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Eric Dumazet <edumazet@kernel.org>
Subject: Re: [PATCH net 2/2] Revert "net: advertise TCP MSS from the configured MTU, not the learned PMTU"
Date: Thu, 29 Oct 2026 18:21:22 +0800 [thread overview]
Message-ID: <22077B76-12B0-4DD6-813E-A3968003575F@gmail.com> (raw)
In-Reply-To: <20261029101859.6893f1a0@pumpkin>
On Thu, 29 Oct 2026, David Laight wrote:
> If it isn't a silly question, how to connections in the other direction
> work?
>
> I'd have thought they'd need that ICMP message to get through.
Not silly at all. The frag-needed always goes back to whoever sent the
oversized packet, and only the client side filters inbound ICMP.
Server -> client (downloads): the server's full-size segment hits the
1456 hop, the router there sends frag-needed back to the server, which
accepts it, learns the PMTU and resends smaller segments. The server's
send side was never changed by 2640e6419594 (tcp_current_mss() still
uses the learned PMTU), so downloads always worked.
Client -> server (uploads): the client's full-size segment hits the same
hop, the frag-needed goes back towards the client (via the relay's
conntrack), and the client-side firewall drops it. The client never
learns to send smaller segments, so the upload stalls. Here the only
thing that kept segments small was the smaller MSS the server
advertised in its SYN-ACK, which is what the reverted commit removed.
Thanks,
Yongjian
next prev parent reply other threads:[~2026-10-29 10:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 7:23 [PATCH net 0/2] Revert advertising the TCP MSS from the configured MTU Esko Mobius via B4 Relay
2026-10-26 7:23 ` [PATCH net 1/2] Revert "selftests: net: packetdrill: add tests for advertised MSS with PMTU exceptions" Esko Mobius via B4 Relay
2026-10-27 11:44 ` Jiayuan Chen
2026-10-26 7:23 ` [PATCH net 2/2] Revert "net: advertise TCP MSS from the configured MTU, not the learned PMTU" Esko Mobius via B4 Relay
2026-10-27 12:45 ` Jiayuan Chen
2026-10-27 13:02 ` Eric Dumazet
2026-10-27 13:12 ` Esko Mobius
2026-10-27 13:44 ` Jiayuan Chen
2026-10-27 23:18 ` Jakub Kicinski
2026-10-28 3:38 ` Esko Mobius
2026-10-28 22:52 ` Jakub Kicinski
2026-10-29 10:18 ` David Laight
2026-10-29 10:21 ` Esko Mobius [this message]
2026-10-29 11:20 ` David Laight
2026-10-29 12:36 ` Esko Mobius
2026-10-26 13:28 ` [PATCH net 0/2] Revert advertising the TCP MSS from the configured MTU Eric Dumazet
2026-10-28 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22077B76-12B0-4DD6-813E-A3968003575F@gmail.com \
--to=echoowall@gmail.com \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiayuan.chen@linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®