From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>,
Rob Herring <robh@kernel.org>,
Chanh Nguyen <chanh@os.amperecomputing.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Khanh Pham <khpham@amperecomputing.com>
Subject: Re: [PATCH] dt-bindings: hwmon: Add adt7462
Date: Thu, 19 Sep 2024 12:39:03 +0200 [thread overview]
Message-ID: <2229b659-c753-4f56-a1ab-7e8984f9147f@kernel.org> (raw)
In-Reply-To: <d825a93f-be5c-45b9-a8d4-5c412ddec232@amperemail.onmicrosoft.com>
On 19/09/2024 11:43, Chanh Nguyen wrote:
>>> +properties:
>>> + compatible:
>>> + const: onnn,adt7462
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + resets:
>>> + maxItems: 1
>>
>> How would this work? 'resets' generally is used for on-chip devices and
>> a reset controller. That doesn't exist at the board level. A standalone
>> device typically uses a GPIO lines if there's a s/w controlled reset.
>> That would be the 'reset-gpios' property.
>>
>
> Thank Rob for your comments! The ADT7462 includes an active low reset
> pin (Pin #14).
>
> I'll change 'resets' into the 'reset-gpios' property.
>
> The example in the binding will be
The question how did it work in the first place is still valid... I
think we might benefit from asking people to post their upstreamed DTS.
Otherwise we will take broken or half-baked bindings, because we never
saw the bigger picture. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-19 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 10:32 Chanh Nguyen
2024-09-18 13:09 ` Krzysztof Kozlowski
2024-09-18 16:07 ` Chanh Nguyen
2024-09-18 17:10 ` Guenter Roeck
2024-09-18 22:09 ` Rob Herring
2024-09-18 22:05 ` Rob Herring
2024-09-19 9:43 ` Chanh Nguyen
2024-09-19 10:39 ` Krzysztof Kozlowski [this message]
2024-09-19 15:02 ` Chanh Nguyen
2024-09-19 15:14 ` Guenter Roeck
2024-09-19 15:54 ` Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2229b659-c753-4f56-a1ab-7e8984f9147f@kernel.org \
--to=krzk@kernel.org \
--cc=chanh@amperemail.onmicrosoft.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=khpham@amperecomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®