Re: [PATCH] dt-bindings: hwmon: Add adt7462

[Chanh Nguyen <chanh@amperemail.onmicrosoft.com>]

On 19/09/2024 05:05, Rob Herring wrote:
> On Wed, Sep 18, 2024 at 10:32:12AM +0000, Chanh Nguyen wrote:
>> Add device tree binding and example for adt7462 device.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>>   .../bindings/hwmon/onnn,adt7462.yaml          | 51 +++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml b/Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml
>> new file mode 100644
>> index 000000000000..4a980cca419a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/onnn,adt7462.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ON Semiconductor ADT7462 Temperature, Voltage Monitor and Fan Controller
>> +
>> +maintainers:
>> +  - Chanh Nguyen <chanh@os.amperecomputing.com>
>> +
>> +description: |
>> +  The ADT7462 has temperature monitors, voltage monitors and multiple PWN Fan
>> +  controllers.
>> +
>> +  The ADT7462 supports monitoring and controlling up to four PWM Fan Drive
>> +  Outputs and eight TACH Inputs Measures. The ADT7462 supports reading a single
>> +  on chip temperature sensor and three remote temperature sensors. There are up
>> +  to 13 voltage monitoring inputs, ranging from 12V to 0.9V.
>> +
>> +  Datasheets:
>> +    https://www.onsemi.com/pub/Collateral/ADT7462-D.PDF
>> +
>> +properties:
>> +  compatible:
>> +    const: onnn,adt7462
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  resets:
>> +    maxItems: 1
> 
> How would this work? 'resets' generally is used for on-chip devices and
> a reset controller. That doesn't exist at the board level. A standalone
> device typically uses a GPIO lines if there's a s/w controlled reset.
> That would be the 'reset-gpios' property.
> 

Thank Rob for your comments! The ADT7462 includes an active low reset 
pin (Pin #14).

I'll change 'resets' into the 'reset-gpios' property.

The example in the binding will be

examples:
   - |
     i2c {
       #address-cells = <1>;
       #size-cells = <0>;

       hwmon@5c {
         compatible = "onnn,adt7462";
         reg = <0x5c>;
         reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
       };
     };


> Rob