From: Dave Hansen <dave.hansen@intel.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
thomas.lendacky@amd.com, "H. Peter Anvin" <hpa@zytor.com>,
hdegoede@redhat.com, Ingo Molnar <mingo@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave.hansen@linux.intel.com>,
David.Kaplan@amd.com, Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
antonio.gomez.iglesias@linux.intel.com
Subject: Re: [PATCH v3 1/2] x86/tsx: Add feature bit for TSX control MSR support
Date: Fri, 18 Nov 2022 10:11:35 -0800 [thread overview]
Message-ID: <22398efc-15c2-4cc5-87a1-7c47c762b283@intel.com> (raw)
In-Reply-To: <de619764e1d98afbb7a5fa58424f1278ede37b45.1668539735.git.pawan.kumar.gupta@linux.intel.com>
On 11/15/22 11:17, Pawan Gupta wrote:
> Support for TSX control MSR is enumerated in MSR_IA32_ARCH_CAPABILITIES.
> This is different from how other CPU features are enumerated i.e. via
> CPUID. Currently a call to tsx_ctrl_is_supported() is required for
> enumerating the feature. In the absence of feature bit for TSX control,
> any code that relies on checking feature bits directly will not work.
>
> In preparation for adding a feature bit check in MSR save/restore during
> suspend/resume, set a new feature bit X86_FEATURE_TSX_CTRL when
> MSR_IA32_TSX_CTRL is present. Also make tsx_ctrl_is_supported() use the
> new feature bit to avoid any overhead of reading the MSR.
Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2022-11-18 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 19:17 [PATCH v3 0/2] Check enumeration before MSR save/restore Pawan Gupta
2022-11-15 19:17 ` [PATCH v3 1/2] x86/tsx: Add feature bit for TSX control MSR support Pawan Gupta
2022-11-18 18:11 ` Dave Hansen [this message]
2022-11-15 19:17 ` [PATCH v3 2/2] x86/pm: Add enumeration check before spec MSRs save/restore setup Pawan Gupta
2022-11-15 19:23 ` Rafael J. Wysocki
2022-11-15 20:48 ` Pawan Gupta
2022-11-18 18:12 ` Dave Hansen
2022-11-18 18:27 ` Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22398efc-15c2-4cc5-87a1-7c47c762b283@intel.com \
--to=dave.hansen@intel.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=David.Kaplan@amd.com \
--cc=antonio.gomez.iglesias@linux.intel.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®