From: Mark Brown <broonie@kernel.org>
To: Baili Deng <bailideng@google.com>
Cc: Guenter Roeck <groeck@google.com>,
David Rau <David.Rau.opensource@dm.renesas.com>,
support.opensource@diasemi.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: da7219: Improve the relability of AAD IRQ process
Date: Wed, 12 Apr 2023 13:09:41 +0100 [thread overview]
Message-ID: <227d1f11-dea0-400a-96c9-dee568730a13@sirena.org.uk> (raw)
In-Reply-To: <CADP_shKfY6-F_4+_eYv=NC9XcgVA+0H3BkCqH8D9wkqJ5SpMDQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Wed, Apr 12, 2023 at 10:32:47AM +0800, Baili Deng wrote:
> The change in the patch done to address the issue Geunter mentioned is that
> da7219_aad_handle_gnd_switch_time() is now called before interrupts are
> enabled. To address the msleep() issue, the delay is now added as a delayed
> work of its own workqueue.
The point with the question was that this sort of stuff should be in the
commit messages. I can't really tell what the change is supposed to do
as things stand.
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-12 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 9:26 David Rau
2023-04-11 11:32 ` Mark Brown
2023-04-11 14:28 ` Guenter Roeck
[not found] ` <CADP_shKfY6-F_4+_eYv=NC9XcgVA+0H3BkCqH8D9wkqJ5SpMDQ@mail.gmail.com>
2023-04-12 12:09 ` Mark Brown [this message]
[not found] ` <OS3PR01MB6641B6FBA5C227B55350DA73CD9B9@OS3PR01MB6641.jpnprd01.prod.outlook.com>
2023-04-12 15:58 ` Mark Brown
2023-04-13 2:41 David Rau
2023-04-13 15:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=227d1f11-dea0-400a-96c9-dee568730a13@sirena.org.uk \
--to=broonie@kernel.org \
--cc=David.Rau.opensource@dm.renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=bailideng@google.com \
--cc=groeck@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®