* VKMS: New plane formats
@ 2021-09-01 20:19 Igor Matheus Andrade Torrente
2021-09-01 20:24 ` Simon Ser
0 siblings, 1 reply; 3+ messages in thread
From: Igor Matheus Andrade Torrente @ 2021-09-01 20:19 UTC (permalink / raw)
To: rodrigosiqueiramelo, melissa.srw, hamohammed.sa, daniel, airlied
Cc: dri-devel, linux-kernel
Hi,
I'm working to add new plane formats to vkms. But I don't know what
should be the behavior in the situation that we received multiple planes
with different formats from the users-space.
For example, if the user chooses:
- DRM_FORMAT_ARGB16161616 to the primary plane
- DRM_FORMAT_ARGB8888 to the cursor
- DRM_FORMAT_YUV42 to the overlay
What should be the output format that will be used to calculate the crc?
DRM_FORMAT_ARGB16161616?
My idea was to convert all the planes to the primary, but I'm not sure
if it is the right approach.
Best regards,
---
Igor M. A. Torrente
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: VKMS: New plane formats
2021-09-01 20:19 VKMS: New plane formats Igor Matheus Andrade Torrente
@ 2021-09-01 20:24 ` Simon Ser
2021-09-02 11:56 ` Igor Matheus Andrade Torrente
0 siblings, 1 reply; 3+ messages in thread
From: Simon Ser @ 2021-09-01 20:24 UTC (permalink / raw)
To: Igor Matheus Andrade Torrente
Cc: rodrigosiqueiramelo, melissa.srw, hamohammed.sa, daniel, airlied,
dri-devel, linux-kernel
Ideally the final composition format would have enough precision for
all of the planes. I think it'd make sense to use ARGB16161616 if the
primary plane uses ARGB8888 and an overlay plane uses ARGB16161616.
To simplify the code, maybe it's fine to always use ARGB16161616 for
the output, and add getters which fetch an ARGB16161616 row for each
supported plane format.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: VKMS: New plane formats
2021-09-01 20:24 ` Simon Ser
@ 2021-09-02 11:56 ` Igor Matheus Andrade Torrente
0 siblings, 0 replies; 3+ messages in thread
From: Igor Matheus Andrade Torrente @ 2021-09-02 11:56 UTC (permalink / raw)
To: Simon Ser
Cc: rodrigosiqueiramelo, melissa.srw, hamohammed.sa, daniel, airlied,
dri-devel, linux-kernel
On 9/1/21 5:24 PM, Simon Ser wrote:
> Ideally the final composition format would have enough precision for
> all of the planes. I think it'd make sense to use ARGB16161616 if the
> primary plane uses ARGB8888 and an overlay plane uses ARGB16161616.
>
> To simplify the code, maybe it's fine to always use ARGB16161616 for
> the output, and add getters which fetch an ARGB16161616 row for each
> supported plane format.
>
This makes sense to me. I will try to implement this way.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-02 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 20:19 VKMS: New plane formats Igor Matheus Andrade Torrente
2021-09-01 20:24 ` Simon Ser
2021-09-02 11:56 ` Igor Matheus Andrade Torrente
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®