mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: tj@kernel.org, leitao@debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tools/workqueue/wq_dump.py: Add busy worker inspection and BH pool states
Date: Sun, 13 Sep 2026 06:01:41 -1000	[thread overview]
Message-ID: <22e5b93e20119d75440a731054e2845a@kernel.org> (raw)
In-Reply-To: <20260911210625.535285-1-atomlin@atomlin.com>

Hello, Aaron.

On Fri, Sep 11, 2026 at 05:06:25PM -0400, Aaron Tomlin wrote:
> +        for bkt in pool.busy_hash:
> +            for worker in hlist_for_each_entry('struct worker', bkt.address_of_(), 'hentry'):

worker->hentry shares storage with the idle-list entry, so a worker going
idle can send this iterator into the circular idle list. Leaving idle can
leave a self-link with WORKER_IDLE clear. The per-worker retries do not
bound either case.

Could you break out of the bucket on an idle worker, a repeated address, or
a traversal read fault? Warn that the pool's busy-worker output is
incomplete and ask the user to retry, then continue with the other pools.
The exception handler needs to cover iterator advancement too.

Thanks.

-- 
tejun

  reply	other threads:[~2026-09-13 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 21:06 Aaron Tomlin
2026-09-13 16:01 ` Tejun Heo [this message]
2026-09-14  8:55 ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22e5b93e20119d75440a731054e2845a@kernel.org \
    --to=tj@kernel.org \
    --cc=atomlin@atomlin.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®