From: Breno Leitao <leitao@debian.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tools/workqueue/wq_dump.py: Add busy worker inspection and BH pool states
Date: Mon, 14 Sep 2026 01:55:36 -0700 [thread overview]
Message-ID: <aqe2MTga350uAoos@gmail.com> (raw)
In-Reply-To: <20260911210625.535285-1-atomlin@atomlin.com>
On Fri, Sep 11, 2026 at 05:06:25PM -0400, Aaron Tomlin wrote:
> @@ -176,6 +202,40 @@ for pi, pool in idr_for_each(worker_pool_idr):
> print(' strict', end='')
> print('')
>
> + if args.busy:
> + for bkt in pool.busy_hash:
> + for worker in hlist_for_each_entry('struct worker', bkt.address_of_(), 'hentry'):
> + for _ in range(3):
> + try:
...
> + except Exception:
> + continue
Is a bare except the right scope here? It swallows all other silly
exceptions, so a typo anywhere in this block makes -b print nothing at
all instead of failing.
I would go for drgn.FaultError and LookupError, these two that are
actually expected.
--breno
prev parent reply other threads:[~2026-09-14 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 21:06 Aaron Tomlin
2026-09-13 16:01 ` Tejun Heo
2026-09-14 8:55 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqe2MTga350uAoos@gmail.com \
--to=leitao@debian.org \
--cc=atomlin@atomlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®