mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: s-vadapalli <s-vadapalli@ti.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: <vigneshr@ti.com>, <s-vadapalli@ti.com>, <lpieralisi@kernel.org>,
	<kwilczynski@kernel.org>, <mani@kernel.org>, <robh@kernel.org>,
	<bhelgaas@google.com>, <linux-omap@vger.kernel.org>,
	<linux-pci@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: j721e: Fix incorrect error message in probe
Date: Sat, 6 Sep 2025 07:17:49 +0530	[thread overview]
Message-ID: <22e63c06-ec7f-4afe-8fc2-f90d49004ce9@ti.com> (raw)
In-Reply-To: <20250905211436.3048282-1-alok.a.tiwari@oracle.com>

On Fri, Sep 05, 2025 at 02:14:34PM -0700, Alok Tiwari wrote:
> The probe function printed "pm_runtime_get_sync failed" when
> j721e_pcie_ctrl_init() returned an error. This is misleading since
> the failure was not from pm_runtime but from the controller init
> routine. Update the error message to correctly reflect the source.
> 
> No functional changes.
> 
> Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> Not sure if a Fixes tag is required here
> ---
>  drivers/pci/controller/cadence/pci-j721e.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index 6c93f39d0288..5e445a7bda33 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -549,7 +549,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
>  
>  	ret = j721e_pcie_ctrl_init(pcie);
>  	if (ret < 0) {
> -		dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
> +		dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
>  		goto err_get_sync;
>  	}

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

  reply	other threads:[~2025-09-06  1:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 21:14 Alok Tiwari
2025-09-06  1:47 ` s-vadapalli [this message]
2025-09-29 18:06 ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22e63c06-ec7f-4afe-8fc2-f90d49004ce9@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=bhelgaas@google.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®