mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] PCI: j721e: Fix incorrect error message in probe
@ 2025-09-05 21:14 Alok Tiwari
  2025-09-06  1:47 ` s-vadapalli
  2025-09-29 18:06 ` Manivannan Sadhasivam
  0 siblings, 2 replies; 3+ messages in thread
From: Alok Tiwari @ 2025-09-05 21:14 UTC (permalink / raw)
  To: vigneshr, s-vadapalli, lpieralisi, kwilczynski, mani, robh,
	bhelgaas, linux-omap, linux-pci, linux-arm-kernel
  Cc: alok.a.tiwari, linux-kernel

The probe function printed "pm_runtime_get_sync failed" when
j721e_pcie_ctrl_init() returned an error. This is misleading since
the failure was not from pm_runtime but from the controller init
routine. Update the error message to correctly reflect the source.

No functional changes.

Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
Not sure if a Fixes tag is required here
---
 drivers/pci/controller/cadence/pci-j721e.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index 6c93f39d0288..5e445a7bda33 100644
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -549,7 +549,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
 
 	ret = j721e_pcie_ctrl_init(pcie);
 	if (ret < 0) {
-		dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
+		dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
 		goto err_get_sync;
 	}
 
-- 
2.50.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: j721e: Fix incorrect error message in probe
  2025-09-05 21:14 [PATCH] PCI: j721e: Fix incorrect error message in probe Alok Tiwari
@ 2025-09-06  1:47 ` s-vadapalli
  2025-09-29 18:06 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 3+ messages in thread
From: s-vadapalli @ 2025-09-06  1:47 UTC (permalink / raw)
  To: Alok Tiwari
  Cc: vigneshr, s-vadapalli, lpieralisi, kwilczynski, mani, robh,
	bhelgaas, linux-omap, linux-pci, linux-arm-kernel, linux-kernel

On Fri, Sep 05, 2025 at 02:14:34PM -0700, Alok Tiwari wrote:
> The probe function printed "pm_runtime_get_sync failed" when
> j721e_pcie_ctrl_init() returned an error. This is misleading since
> the failure was not from pm_runtime but from the controller init
> routine. Update the error message to correctly reflect the source.
> 
> No functional changes.
> 
> Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> Not sure if a Fixes tag is required here
> ---
>  drivers/pci/controller/cadence/pci-j721e.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index 6c93f39d0288..5e445a7bda33 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -549,7 +549,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
>  
>  	ret = j721e_pcie_ctrl_init(pcie);
>  	if (ret < 0) {
> -		dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
> +		dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
>  		goto err_get_sync;
>  	}

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: j721e: Fix incorrect error message in probe
  2025-09-05 21:14 [PATCH] PCI: j721e: Fix incorrect error message in probe Alok Tiwari
  2025-09-06  1:47 ` s-vadapalli
@ 2025-09-29 18:06 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2025-09-29 18:06 UTC (permalink / raw)
  To: vigneshr, s-vadapalli, lpieralisi, kwilczynski, robh, bhelgaas,
	linux-omap, linux-pci, linux-arm-kernel, Alok Tiwari
  Cc: linux-kernel


On Fri, 05 Sep 2025 14:14:34 -0700, Alok Tiwari wrote:
> The probe function printed "pm_runtime_get_sync failed" when
> j721e_pcie_ctrl_init() returned an error. This is misleading since
> the failure was not from pm_runtime but from the controller init
> routine. Update the error message to correctly reflect the source.
> 
> No functional changes.
> 
> [...]

Applied, thanks!

[1/1] PCI: j721e: Fix incorrect error message in probe
      commit: cfcd6cab2f33c24a68517f9e3131480b4000c2be

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-29 18:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-05 21:14 [PATCH] PCI: j721e: Fix incorrect error message in probe Alok Tiwari
2025-09-06  1:47 ` s-vadapalli
2025-09-29 18:06 ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®