[PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR

[PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR

[Arnd Bergmann]

The THERMAL_GOV_POWER_ALLOCATOR symbol requires CONFIG_ENERGY_MODEL:

WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
  Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
  Selected by [y]:
  - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>

Add this as a dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to
avoid creating invalid configurations.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/thermal/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 59b79fc48266..712bcd668a4d 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -109,6 +109,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
 config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
 	bool "power_allocator"
 	select THERMAL_GOV_POWER_ALLOCATOR
+	depends on ENERGY_MODEL
 	help
 	  Select this if you want to control temperature based on
 	  system and device power allocation. This governor can only
-- 
2.20.0

Re: [PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR

[Daniel Lezcano]

On 10/12/2019 21:41, Arnd Bergmann wrote:
> The THERMAL_GOV_POWER_ALLOCATOR symbol requires CONFIG_ENERGY_MODEL:
> 
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
>   Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
>   Selected by [y]:
>   - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
> 
> Add this as a dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to
> avoid creating invalid configurations.

Hi Arnd,

thanks for the patch. The problem is already fixed.

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog