[PATCH] clk: nomadik: Correct str_enabled_disabled() SXTALO case

[PATCH] clk: nomadik: Correct str_enabled_disabled() SXTALO case

[Krzysztof Kozlowski]

Commit 1cd1c8f400e9 ("clk: Use str_enable_disable-like helpers") should
use reversed check for SXTALO.

Reported-by: Stanislav Jakubek <stano.jakubek@gmail.com>
Closes: https://lore.kernel.org/all/Z4diEj__bbQl4ULS@standask-GA-A55M-S2HP/
Fixes: 1cd1c8f400e9 ("clk: Use str_enable_disable-like helpers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/clk/clk-nomadik.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index f3a73ac5a1b9..fc0aeb4247f2 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -117,7 +117,7 @@ static void __init nomadik_src_init(void)
 
 	val = readl(src_base + SRC_XTALCR);
 	pr_info("SXTALO is %s\n",
-		str_enabled_disabled(val & SRC_XTALCR_SXTALDIS));
+		str_disabled_enabled(val & SRC_XTALCR_SXTALDIS));
 	pr_info("MXTAL is %s\n",
 		str_enabled_disabled(val & SRC_XTALCR_MXTALSTAT));
 	if (of_property_read_bool(np, "disable-sxtalo")) {
-- 
2.43.0

Re: [PATCH] clk: nomadik: Correct str_enabled_disabled() SXTALO case

[Linus Walleij]

On Wed, Jan 15, 2025 at 9:19 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> Commit 1cd1c8f400e9 ("clk: Use str_enable_disable-like helpers") should
> use reversed check for SXTALO.
>
> Reported-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> Closes: https://lore.kernel.org/all/Z4diEj__bbQl4ULS@standask-GA-A55M-S2HP/
> Fixes: 1cd1c8f400e9 ("clk: Use str_enable_disable-like helpers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks a lot for fixing up this Krzysztof!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH] clk: nomadik: Correct str_enabled_disabled() SXTALO case

[Stephen Boyd]

Quoting Krzysztof Kozlowski (2025-01-15 00:19:14)
> Commit 1cd1c8f400e9 ("clk: Use str_enable_disable-like helpers") should
> use reversed check for SXTALO.
> 
> Reported-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> Closes: https://lore.kernel.org/all/Z4diEj__bbQl4ULS@standask-GA-A55M-S2HP/
> Fixes: 1cd1c8f400e9 ("clk: Use str_enable_disable-like helpers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Applied to clk-next