* [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
@ 2021-07-15 2:05 Yang Yingliang
2021-07-15 9:30 ` Thomas Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2021-07-15 2:05 UTC (permalink / raw)
To: linux-kernel, dri-devel, virtualization
Cc: kraxel, airlied, daniel, tzimmermann
Replace pci_enable_device() with pcim_enable_device(),
pci_disable_device() will be called in release automatically.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v2:
use pcim_enable_device()
---
drivers/gpu/drm/tiny/bochs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index a2cfecfa8556..73415fa9ae0f 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -648,7 +648,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent
if (IS_ERR(dev))
return PTR_ERR(dev);
- ret = pci_enable_device(pdev);
+ ret = pcim_enable_device(pdev);
if (ret)
goto err_free_dev;
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
2021-07-15 2:05 [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe() Yang Yingliang
@ 2021-07-15 9:30 ` Thomas Zimmermann
2021-07-15 11:03 ` Yang Yingliang
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Zimmermann @ 2021-07-15 9:30 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, dri-devel, virtualization; +Cc: airlied, kraxel
[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]
Hi,
for the change
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
but there are some style issues AFAICS.
Am 15.07.21 um 04:05 schrieb Yang Yingliang:
> Replace pci_enable_device() with pcim_enable_device(),
> pci_disable_device() will be called in release automatically.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
S-o-b line goes first
> ---
> v2:
> use pcim_enable_device()
This changelog should rather be located between the commit description
and the first S-o-b line.
Best regards
Thomas
> ---
> drivers/gpu/drm/tiny/bochs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
> index a2cfecfa8556..73415fa9ae0f 100644
> --- a/drivers/gpu/drm/tiny/bochs.c
> +++ b/drivers/gpu/drm/tiny/bochs.c
> @@ -648,7 +648,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent
> if (IS_ERR(dev))
> return PTR_ERR(dev);
>
> - ret = pci_enable_device(pdev);
> + ret = pcim_enable_device(pdev);
> if (ret)
> goto err_free_dev;
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
2021-07-15 9:30 ` Thomas Zimmermann
@ 2021-07-15 11:03 ` Yang Yingliang
2021-07-15 11:45 ` Thomas Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2021-07-15 11:03 UTC (permalink / raw)
To: Thomas Zimmermann, linux-kernel, dri-devel, virtualization
Cc: airlied, kraxel
On 2021/7/15 17:30, Thomas Zimmermann wrote:
> Hi,
>
> for the change
>
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
>
> but there are some style issues AFAICS.
OK, need I resend it with the style changes and your ack ?
>
> Am 15.07.21 um 04:05 schrieb Yang Yingliang:
>> Replace pci_enable_device() with pcim_enable_device(),
>> pci_disable_device() will be called in release automatically.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> S-o-b line goes first
>
>> ---
>> v2:
>> use pcim_enable_device()
>
> This changelog should rather be located between the commit description
> and the first S-o-b line.
>
> Best regards
> Thomas
>
>> ---
>> drivers/gpu/drm/tiny/bochs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
>> index a2cfecfa8556..73415fa9ae0f 100644
>> --- a/drivers/gpu/drm/tiny/bochs.c
>> +++ b/drivers/gpu/drm/tiny/bochs.c
>> @@ -648,7 +648,7 @@ static int bochs_pci_probe(struct pci_dev *pdev,
>> const struct pci_device_id *ent
>> if (IS_ERR(dev))
>> return PTR_ERR(dev);
>> - ret = pci_enable_device(pdev);
>> + ret = pcim_enable_device(pdev);
>> if (ret)
>> goto err_free_dev;
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
2021-07-15 11:03 ` Yang Yingliang
@ 2021-07-15 11:45 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2021-07-15 11:45 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, dri-devel, virtualization; +Cc: airlied, kraxel
[-- Attachment #1.1: Type: text/plain, Size: 1817 bytes --]
Hi
Am 15.07.21 um 13:03 schrieb Yang Yingliang:
>
> On 2021/7/15 17:30, Thomas Zimmermann wrote:
>> Hi,
>>
>> for the change
>>
>>
>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>>
>> but there are some style issues AFAICS.
> OK, need I resend it with the style changes and your ack ?
Please do. I'll merge it a few days later if no further comments come in.
Best regards
Thomas
>>
>> Am 15.07.21 um 04:05 schrieb Yang Yingliang:
>>> Replace pci_enable_device() with pcim_enable_device(),
>>> pci_disable_device() will be called in release automatically.
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>>
>> S-o-b line goes first
>>
>>> ---
>>> v2:
>>> use pcim_enable_device()
>>
>> This changelog should rather be located between the commit description
>> and the first S-o-b line.
>>
>> Best regards
>> Thomas
>>
>>> ---
>>> drivers/gpu/drm/tiny/bochs.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
>>> index a2cfecfa8556..73415fa9ae0f 100644
>>> --- a/drivers/gpu/drm/tiny/bochs.c
>>> +++ b/drivers/gpu/drm/tiny/bochs.c
>>> @@ -648,7 +648,7 @@ static int bochs_pci_probe(struct pci_dev *pdev,
>>> const struct pci_device_id *ent
>>> if (IS_ERR(dev))
>>> return PTR_ERR(dev);
>>> - ret = pci_enable_device(pdev);
>>> + ret = pcim_enable_device(pdev);
>>> if (ret)
>>> goto err_free_dev;
>>>
>>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-15 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 2:05 [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe() Yang Yingliang
2021-07-15 9:30 ` Thomas Zimmermann
2021-07-15 11:03 ` Yang Yingliang
2021-07-15 11:45 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®