* [PATCH] PM / wakeup: wakeup_source_create: use kstrdup_const
@ 2015-09-09 21:42 Rasmus Villemoes
2015-10-05 20:47 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2015-09-09 21:42 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman
Cc: Rasmus Villemoes, linux-pm, linux-kernel
Using kstrdup_const allows us to save a little runtime memory (and a
string copy) in the common case where name is a string literal.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/base/power/wakeup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 51f15bc15774..332e607e0030 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -91,7 +91,7 @@ struct wakeup_source *wakeup_source_create(const char *name)
if (!ws)
return NULL;
- wakeup_source_prepare(ws, name ? kstrdup(name, GFP_KERNEL) : NULL);
+ wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_KERNEL) : NULL);
return ws;
}
EXPORT_SYMBOL_GPL(wakeup_source_create);
@@ -154,7 +154,7 @@ void wakeup_source_destroy(struct wakeup_source *ws)
wakeup_source_drop(ws);
wakeup_source_record(ws);
- kfree(ws->name);
+ kfree_const(ws->name);
kfree(ws);
}
EXPORT_SYMBOL_GPL(wakeup_source_destroy);
--
2.1.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / wakeup: wakeup_source_create: use kstrdup_const
2015-09-09 21:42 [PATCH] PM / wakeup: wakeup_source_create: use kstrdup_const Rasmus Villemoes
@ 2015-10-05 20:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-10-05 20:47 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Len Brown, Pavel Machek, Greg Kroah-Hartman, linux-pm, linux-kernel
On Wednesday, September 09, 2015 11:42:06 PM Rasmus Villemoes wrote:
> Using kstrdup_const allows us to save a little runtime memory (and a
> string copy) in the common case where name is a string literal.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-05 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-09 21:42 [PATCH] PM / wakeup: wakeup_source_create: use kstrdup_const Rasmus Villemoes
2015-10-05 20:47 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®