From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: drop port description
Date: Fri, 22 Mar 2024 12:35:34 +0000 [thread overview]
Message-ID: <230eab52-9751-43fd-8e47-fbfe12410e44@linaro.org> (raw)
In-Reply-To: <20240322-typec-fix-example-v1-1-6b01c347419e@linaro.org>
On 22/03/2024 11:52, Dmitry Baryshkov wrote:
> The PMIC Type-C controller doesn't have separate role-switching signal.
> Instead it has an HS signal connection between embedded USB-C connector
> node and the HS port of the USB controller.
I take your point on port as a signal but the way type-c determines
data-role is via the DR_Swap message.
https://www.embedded.com/usb-type-c-and-power-delivery-101-power-delivery-protocol/
We receive an IRQ which is a packet containing DR_Swap - TCPM consumes
that data and does a data-role switch.
The port then establishes the link between typec-port and redriver or PHY.
So, I think HS should be dropped from the commit logs and names in both
series.
BTW for the GLINK devices I think the adsp firmware just notifies the
APSS of the data-role switch so, these types of devices probably should
have an epdoint with "usb_role_switch" in the name.
---
bod
next prev parent reply other threads:[~2024-03-22 12:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 11:52 [PATCH 0/2] dt-bindings: usb: qcom,pmic-typec: OF graph corrections Dmitry Baryshkov
2024-03-22 11:52 ` [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: drop port description Dmitry Baryshkov
2024-03-22 12:35 ` Bryan O'Donoghue [this message]
2024-03-22 13:28 ` Dmitry Baryshkov
2024-03-22 14:52 ` Bryan O'Donoghue
2024-03-22 15:09 ` neil.armstrong
2024-03-22 15:23 ` Bryan O'Donoghue
2024-03-22 15:49 ` Dmitry Baryshkov
2024-03-22 18:36 ` Rob Herring
2024-03-22 19:08 ` Dmitry Baryshkov
2024-03-22 20:44 ` Bryan O'Donoghue
2024-03-22 22:31 ` Dmitry Baryshkov
2024-03-22 11:52 ` [PATCH 2/2] dt-bindings: usb: qcom,pmic-typec: update example to follow connector schema Dmitry Baryshkov
2024-03-22 18:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230eab52-9751-43fd-8e47-fbfe12410e44@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®