From: neil.armstrong@linaro.org
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: drop port description
Date: Fri, 22 Mar 2024 16:09:06 +0100 [thread overview]
Message-ID: <c0f1e898-7638-4b7b-a938-9e31e5b57e57@linaro.org> (raw)
In-Reply-To: <5ea4a187-1971-4970-a289-826d96c0351a@linaro.org>
On 22/03/2024 15:52, Bryan O'Donoghue wrote:
> On 22/03/2024 13:28, Dmitry Baryshkov wrote:
>> Then the actual usage doesn't match the schema. usb-c-connector
>> clearly defines HS, SS and SBU ports
>
> Its a bit restrictive IMO, data-role and power-role switching is not limited to HS and in fact can be done with a GPIO for example.
>
> /Looks in Documentation/devicetree/bindings/connector/usb-connector.yaml
>
> Yeah I mean this just doesn't cover all use-cases ..
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> description: OF graph bindings modeling any data bus to the connector
> unless the bus is between parent node and the connector. Since a single
> connector can have multiple data buses every bus has an assigned OF graph
> port number as described below.
>
> properties:
> port@0:
> $ref: /schemas/graph.yaml#/properties/port
> description: High Speed (HS), present in all connectors.
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
> description: Super Speed (SS), present in SS capable connectors.
>
> port@2:
> $ref: /schemas/graph.yaml#/properties/port
> description: Sideband Use (SBU), present in USB-C. This describes the
> alternate mode connection of which SBU is a part.
>
> TBH I think we should drop this HS, SS stuff from the connector definition - there's nothing to say in a h/w definition anywhere HS must be a port or indeed SS - not all hardware knows or cares about different HS/SS signalling.
It matches the USB-C connector electrical characteristics, which by spec has, at least:
- High-Speed USB Line
- up to 4 differential high-speed lanes that can be switched to DP, USB2 or PCIe
- SideBand line (SBU)
And those 3 components can be handled by 3 different HW in the SoC, so each one has a dedicated port.
Remember DT describes the HW, not the SW implementation.
Neil
>
> Documentation bit-rot
>
> ---
> bod
>
next prev parent reply other threads:[~2024-03-22 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 11:52 [PATCH 0/2] dt-bindings: usb: qcom,pmic-typec: OF graph corrections Dmitry Baryshkov
2024-03-22 11:52 ` [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: drop port description Dmitry Baryshkov
2024-03-22 12:35 ` Bryan O'Donoghue
2024-03-22 13:28 ` Dmitry Baryshkov
2024-03-22 14:52 ` Bryan O'Donoghue
2024-03-22 15:09 ` neil.armstrong [this message]
2024-03-22 15:23 ` Bryan O'Donoghue
2024-03-22 15:49 ` Dmitry Baryshkov
2024-03-22 18:36 ` Rob Herring
2024-03-22 19:08 ` Dmitry Baryshkov
2024-03-22 20:44 ` Bryan O'Donoghue
2024-03-22 22:31 ` Dmitry Baryshkov
2024-03-22 11:52 ` [PATCH 2/2] dt-bindings: usb: qcom,pmic-typec: update example to follow connector schema Dmitry Baryshkov
2024-03-22 18:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f1e898-7638-4b7b-a938-9e31e5b57e57@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®