mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
	Su Hui <suhui@nfschina.com>,
	linuxppc-dev@lists.ozlabs.org,
	Christophe Leroy <chleroy@kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device_add()
Date: Mon, 29 Dec 2025 15:28:27 +0100	[thread overview]
Message-ID: <231f6f66-6a3d-4166-9e1a-ae0d5bd7583d@web.de> (raw)
In-Reply-To: <20251224104433.1585576-1-lihaoxiang@isrc.iscas.ac.cn>

> If device_add() fails, call put_device() to drop the device
> reference.

Can the word wrapping become nicer?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n659


>            And put_device() triggers fsl_mc_device_release()
> which does the free. Thus just return after call put_device().

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n145

Regards,
Markus

  reply	other threads:[~2025-12-29 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-24 10:44 Haoxiang Li
2025-12-29 14:28 ` Markus Elfring [this message]
2026-01-23 11:10 ` Ioana Ciornei
2026-01-23 11:35   ` Haoxiang Li
2026-01-23 11:46     ` Ioana Ciornei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=231f6f66-6a3d-4166-9e1a-ae0d5bd7583d@web.de \
    --to=markus.elfring@web.de \
    --cc=chleroy@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=lihaoxiang@isrc.iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=suhui@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®