mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wangrongwei <rongwei.wang@linux.alibaba.com>
To: Will Deacon <will@kernel.org>
Cc: catalin.marinas@arm.com, bjorn.andersson@linaro.org,
	shawnguo@kernel.org, vkoul@kernel.org, geert+renesas@glider.be,
	Anson.Huang@nxp.com, michael@walle.cc, krzk@kernel.org,
	olof@lixom.net, vincenzo.frascino@arm.com, ardb@kernel.org,
	masahiroy@kernel.org, gshan@redhat.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] arm64:msr: Add MSR driver
Date: Tue, 1 Dec 2020 13:44:07 +0800	[thread overview]
Message-ID: <232411A5-A587-42D8-B9B3-CDCC0A5F9ADE@linux.alibaba.com> (raw)
In-Reply-To: <20201130175706.GA25457@willie-the-truck>

Hi, Will
Thanks for your reply!
There are absolutely privileged registers, and seriously expose the interface directly! 
However, these interfaces (/dev/cpu/<N>/msr) need permissions to access, so there should be few security issues. In addition, it may be due to my unclear description above. This driver is mainly a debugging tool. It make developers can easily get the values of some system registers without modifying the kernel.
In fact, we first considered the /dev/mem solution, but it seems that /dev/mem can map peripheral or IO registers, but not system registers.

> 2020年12月1日 上午1:57,Will Deacon <will@kernel.org> 写道:
> 
> On Tue, Dec 01, 2020 at 01:48:30AM +0800, Rongwei Wang wrote:
>> MSR ARM driver aims to provide interfacs for user to read or write data to all
>> system registers. Its functions is same as MSR driver (x86 platform). It mainly
>> depends on kprobe and undef exception to read or write system registers
>> dynamicly.
> 
> ... but why? These are privileged registers for a reason, and giving
> userspace access to them is bound to cause serious problems. Why can't we
> do whatever it is that userspace is trying to do by poking these things in
> the kernel instead? This interface is a bit like using /dev/mem instead of
> writing a proper device driver.
> 
> Thanks,
> 
> Will


  parent reply	other threads:[~2020-12-01  5:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 17:48 Rongwei Wang
2020-11-30 17:48 ` [PATCH 1/3] arm64:insn: Export symbols for MSR ARM driver Rongwei Wang
2020-11-30 17:48 ` [PATCH 2/3] arm64:msr: Introduce " Rongwei Wang
2020-11-30 17:48 ` [PATCH 3/3] arm64:msr: Enable " Rongwei Wang
2020-11-30 17:57 ` [PATCH 0/3] arm64:msr: Add MSR driver Will Deacon
2020-12-01  2:55   ` wangrongwei
2020-12-01  5:44   ` wangrongwei [this message]
2020-11-30 18:05 ` Marc Zyngier
2020-11-30 18:20   ` Randy Dunlap
2020-12-01  3:09   ` wangrongwei
2020-12-01  8:12     ` Marc Zyngier
2020-12-01 14:25       ` wangrongwei
2020-12-01 15:37         ` Marc Zyngier
2020-12-03  5:45           ` Rongwei Wang
2020-12-03  8:35             ` Marc Zyngier
2020-12-03 11:25               ` Rongwei Wang
2020-12-03 11:45                 ` Marc Zyngier
2020-12-03 12:22                   ` Rongwei Wang
2020-12-03 11:50                 ` Mark Rutland
2020-11-30 19:03 ` Borislav Petkov
2020-12-01  3:44   ` wangrongwei
2020-12-01 11:26     ` Borislav Petkov
2020-12-01 14:33       ` wangrongwei
2020-12-01 14:54         ` Borislav Petkov
2020-12-01 15:17           ` Rongwei Wang
2020-12-01 15:25             ` Borislav Petkov
2020-12-03  2:09               ` Rongwei Wang
2020-12-01 15:26             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=232411A5-A587-42D8-B9B3-CDCC0A5F9ADE@linux.alibaba.com \
    --to=rongwei.wang@linux.alibaba.com \
    --cc=Anson.Huang@nxp.com \
    --cc=ardb@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=geert+renesas@glider.be \
    --cc=gshan@redhat.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michael@walle.cc \
    --cc=olof@lixom.net \
    --cc=shawnguo@kernel.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®