mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: dirk.brandewie@gmail.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: Re: [PATCH v2] intel_pstate: Use LFM bus ratio as min ratio/P state
Date: Thu, 20 Feb 2014 01:44:04 +0100	[thread overview]
Message-ID: <2338280.snAhRfpdt9@vostro.rjw.lan> (raw)
In-Reply-To: <1392834925-21648-1-git-send-email-dirk.j.brandewie@intel.com>

On Wednesday, February 19, 2014 10:35:25 AM dirk.brandewie@gmail.com wrote:
> From: Dirk Brandewie <dirk.j.brandewie@intel.com>
> 
> LFM (max efficiency ratio) is the max frequency at minimum voltage
> supported by the processor.  Using LFM as the minimum P state
> increases performmance without affecting power. By not using P states
> below LFM we avoid using P states that are less power efficient.
> 
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>

Thanks!  I've replaced the original changelog with the one above.

> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b80c03d..ff45ce1 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -356,7 +356,7 @@ static int byt_get_min_pstate(void)
>  {
>  	u64 value;
>  	rdmsrl(BYT_RATIOS, value);
> -	return value & 0xFF;
> +	return (value >> 8) & 0xFF;
>  }
>  
>  static int byt_get_max_pstate(void)
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2014-02-20  0:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 18:01 [PATCH 0/5] intel_pstate updates for v3.14-rcX dirk.brandewie
2014-02-12 18:01 ` [PATCH 1/5] intel_pstate: Remove energy reporting from pstate_sample tracepoint dirk.brandewie
2014-02-12 18:01 ` [PATCH 2/5] intel_pstate: remove unneeded sample buffers dirk.brandewie
2014-02-13  0:42   ` Li, Aubrey
2014-02-12 18:01 ` [PATCH 3/5] intel_pstate: fix pid_reset to use fixed point values dirk.brandewie
2014-02-12 18:01 ` [PATCH 4/5] intel_pstate: Use LFM bus ratio as min ratio/P state dirk.brandewie
2014-02-19  0:58   ` Rafael J. Wysocki
2014-02-19 18:35     ` [PATCH v2] " dirk.brandewie
2014-02-20  0:44       ` Rafael J. Wysocki [this message]
2014-02-12 18:01 ` [PATCH 5/5] intel_pstate: Add support for Baytrail turbo P states dirk.brandewie
2014-02-13  0:47 ` [PATCH 0/5] intel_pstate updates for v3.14-rcX Rafael J. Wysocki
2014-02-13  1:00   ` Rafael J. Wysocki
2014-02-13  1:23     ` Rafael J. Wysocki
2014-02-18 20:29 ` Dirk Brandewie
2014-02-18 22:27   ` Rafael J. Wysocki
2014-02-18 23:53     ` Dirk Brandewie
2014-02-19  0:34       ` Rafael J. Wysocki
     [not found]         ` <CANOOhLToR8ajjiM1x7m_4Pbak3sUkjfq0h4EX6dz1U23D3X3EA@mail.gmail.com>
2014-02-19  0:43           ` Rafael J. Wysocki
2014-02-19  0:35             ` Dirk Brandewie
2014-02-19  0:53               ` Rafael J. Wysocki
2014-02-19 18:26                 ` Dirk Brandewie
2014-02-20  0:43                   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2338280.snAhRfpdt9@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=dirk.brandewie@gmail.com \
    --cc=dirk.j.brandewie@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®