From: "H. Peter Anvin" <hpa@zytor.com>
To: Max Filippov <jcmvbkbc@gmail.com>, linux-kernel@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
Guenter Roeck <linux@roeck-us.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH 2/3] x86: don't use echo -e needlessly
Date: Thu, 22 Aug 2013 17:11:22 +0200 [thread overview]
Message-ID: <233f60e2-1706-42b0-8db1-13290fb7e459@email.android.com> (raw)
In-Reply-To: <1377183186-8407-3-git-send-email-jcmvbkbc@gmail.com>
Can we drop the /bin/?
Max Filippov <jcmvbkbc@gmail.com> wrote:
>-e is not needed to output strings without escape sequences.
>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Cc: Ingo Molnar <mingo@redhat.com>
>Cc: "H. Peter Anvin" <hpa@zytor.com>
>Cc: x86@kernel.org
>Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>---
> arch/x86/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 07639c6..7386e8a 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -95,7 +95,7 @@ endif
>
> ifdef CONFIG_X86_X32
> x32_ld_ok := $(call try-run,\
>- /bin/echo -e '1: .quad 1b' | \
>+ /bin/echo '1: .quad 1b' | \
> $(CC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" - && \
> $(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMPO" && \
> $(LD) -m elf32_x86_64 "$$TMPO" -o "$$TMP",y,n)
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-08-22 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 14:53 [PATCH 0/3] clean up echo -e usage Max Filippov
2013-08-22 14:53 ` [PATCH 1/3] xtensa: don't use echo -e needlessly Max Filippov
2013-08-22 14:53 ` [PATCH 2/3] x86: " Max Filippov
2013-08-22 15:11 ` H. Peter Anvin [this message]
2013-08-22 15:17 ` Max Filippov
2013-08-22 14:53 ` [PATCH 3/3] raid6/test: replace echo -e with printf Max Filippov
2013-08-22 15:09 ` H. Peter Anvin
2013-08-26 4:15 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=233f60e2-1706-42b0-8db1-13290fb7e459@email.android.com \
--to=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®