mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Max Filippov <jcmvbkbc@gmail.com>, linux-kernel@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Guenter Roeck <linux@roeck-us.net>, NeilBrown <neilb@suse.de>,
	Jim Kukunas <james.t.kukunas@linux.intel.com>,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 3/3] raid6/test: replace echo -e with printf
Date: Thu, 22 Aug 2013 17:09:11 +0200	[thread overview]
Message-ID: <d44b178f-0c43-483d-80f5-9791573bc526@email.android.com> (raw)
In-Reply-To: <1377183186-8407-4-git-send-email-jcmvbkbc@gmail.com>

Acked-by: H. Peter Anvin <hpa@zytor.com>

Max Filippov <jcmvbkbc@gmail.com> wrote:
>-e is a non-standard echo option, echo output is
>implementation-dependent when it is used. Replace echo -e with printf
>as
>suggested by POSIX echo manual.
>
>Cc: NeilBrown <neilb@suse.de>
>Cc: Jim Kukunas <james.t.kukunas@linux.intel.com>
>Cc: "H. Peter Anvin" <hpa@zytor.com>
>Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>---
> lib/raid6/test/Makefile |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
>index 087332d..73b0151 100644
>--- a/lib/raid6/test/Makefile
>+++ b/lib/raid6/test/Makefile
>@@ -28,7 +28,7 @@ ifeq ($(IS_X86),yes)
>                     gcc -c -x assembler - >&/dev/null &&	\
>                     rm ./-.o && echo -DCONFIG_AS_AVX2=1)
> else
>-        HAS_ALTIVEC := $(shell echo -e '\#include <altivec.h>\nvector
>int a;' |\
>+        HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector
>int a;\n' |\
>                          gcc -c -x c - >&/dev/null && \
>                          rm ./-.o && echo yes)
>         ifeq ($(HAS_ALTIVEC),yes)

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.

  reply	other threads:[~2013-08-22 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 14:53 [PATCH 0/3] clean up echo -e usage Max Filippov
2013-08-22 14:53 ` [PATCH 1/3] xtensa: don't use echo -e needlessly Max Filippov
2013-08-22 14:53 ` [PATCH 2/3] x86: " Max Filippov
2013-08-22 15:11   ` H. Peter Anvin
2013-08-22 15:17     ` Max Filippov
2013-08-22 14:53 ` [PATCH 3/3] raid6/test: replace echo -e with printf Max Filippov
2013-08-22 15:09   ` H. Peter Anvin [this message]
2013-08-26  4:15     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d44b178f-0c43-483d-80f5-9791573bc526@email.android.com \
    --to=hpa@zytor.com \
    --cc=james.t.kukunas@linux.intel.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=neilb@suse.de \
    --cc=sam@ravnborg.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®