mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Florian Weimer" <fweimer@redhat.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Uros Bizjak" <ubizjak@gmail.com>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	kernel-dev@igalia.com
Subject: Re: [PATCH v8 4/4] arm64: vdso32: Implement __vdso_futex_robust_try_unlock()
Date: Thu, 17 Sep 2026 11:41:15 -0300	[thread overview]
Message-ID: <23596300-b89e-4cff-a6ce-e7bf54e90c05@igalia.com> (raw)
In-Reply-To: <aqvGEiZEtZFEWvjL@J2N7QTR9R3>

Em 17/09/2026 07:50, Mark Rutland escreveu:
> On Wed, Sep 16, 2026 at 10:11:01PM -0300, André Almeida wrote:
>> Em 16/09/2026 11:28, Mark Rutland escreveu:
>>> On Fri, Aug 21, 2026 at 06:50:45PM -0300, André Almeida wrote:
>>>> Based on aarch64 implementation, provide a 32 bit entry point for
>>>> this vDSO.
>>>>
>>>> In order to keep compatibility with arm64_futex_robust_unlock_get_pop(),
>>>> make sure to store the pop address at r2 and the compare result value
>>>> at r3.
>>>
>>> Before we add this to the compat vdso, we'll need to implement this on
>>> arch/arm/.
>>>
>>> Otherwise, my comments on the patch for the native vdso functions apply
>>> here too.
>>
>> Right, and the compat entry point at arch/arm64/ would point to the
>> __vdso_futex_robust_list32_try_unlock implementation at arch/arm/?
> 
> So far we've had arm64 provide its own copy (which e.g. might use
> sequences relying on ARMv8+ instructions), so I think we'd do the same
> here.
> 
> The key thing is that 32-bit tasks on arm64 should see the same ABI as
> native tasks on 32-bit arm. As there's a risk that 32-bit arm might have
> some ABI quirks (e.g. due to older processors), we don't want to enable
> features for compat tasks on arm64 before that's been implemented on
> 32-bit arm.
Gotcha, makes perfect sense.

Thanks!
	André

      reply	other threads:[~2026-09-17 14:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 21:50 [PATCH v8 0/4] arm64: vdso: " André Almeida
2026-08-21 21:50 ` [PATCH v8 1/4] arm64: vdso: Prepare for robust futex unlock support André Almeida
2026-09-16 14:24   ` Mark Rutland
2026-09-17  1:05     ` André Almeida
2026-09-17 10:01       ` Mark Rutland
2026-09-17 14:40         ` André Almeida
2026-08-21 21:50 ` [PATCH v8 2/4] arm64: vdso: Implement __vdso_futex_robust_try_unlock() André Almeida
2026-09-16 14:27   ` Mark Rutland
2026-09-17  1:06     ` André Almeida
2026-09-17 10:45       ` Mark Rutland
2026-08-21 21:50 ` [PATCH v8 3/4] arm64: vdso32: Bring vdso32-offsets.h back André Almeida
2026-08-21 21:50 ` [PATCH v8 4/4] arm64: vdso32: Implement __vdso_futex_robust_try_unlock() André Almeida
2026-09-16 14:28   ` Mark Rutland
2026-09-17  1:11     ` André Almeida
2026-09-17 10:50       ` Mark Rutland
2026-09-17 14:41         ` André Almeida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23596300-b89e-4cff-a6ce-e7bf54e90c05@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=fweimer@redhat.com \
    --cc=kernel-dev@igalia.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=ubizjak@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®