[PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[tanzheng]

There is no need to call wiphy_dev again.Simplifying the
code makes it more readable.

Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
Changes in v3:
- Modify the patch description	

Changes in v2:
- Delete the use of dev_name instead of pdev->driver->name.
  This is incorrect.

 net/wireless/ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/ethtool.c b/net/wireless/ethtool.c
index 2613d6ac0fda..46e4317cbd7e 100644
--- a/net/wireless/ethtool.c
+++ b/net/wireless/ethtool.c
@@ -23,7 +23,7 @@ void cfg80211_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 	else
 		strscpy(info->fw_version, "N/A", sizeof(info->fw_version));
 
-	strscpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)),
+	strscpy(info->bus_info, dev_name(pdev),
 		sizeof(info->bus_info));
 }
 EXPORT_SYMBOL(cfg80211_get_drvinfo);
-- 
2.25.1

Re: [PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[Johannes Berg]

On Fri, 2025-09-05 at 14:39 +0800, tanzheng wrote:
> There is no need to call wiphy_dev again.Simplifying the
> code makes it more readable.
> 
> Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
> 

The bot complains this doesn't match your From: line, is that
intentional?

johannes

Re: [PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[tanzheng]

>> There is no need to call wiphy_dev again.Simplifying the
>> code makes it more readable.
>> 
>> Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
>> 
>
>The bot complains this doesn't match your From: line, is that
>intentional?

Yes, I set it up this way on purpose. Sorry, I don't know 
this rule. I'll modify Signed-off-by. Thank you for your comment.

Best regards,
TanZheng

Re: [PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[Johannes Berg]

On Mon, 2025-09-08 at 09:45 +0800, tanzheng wrote:
> > > There is no need to call wiphy_dev again.Simplifying the
> > > code makes it more readable.
> > > 
> > > Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
> > > 
> > 
> > The bot complains this doesn't match your From: line, is that
> > intentional?
> 
> Yes, I set it up this way on purpose. Sorry, I don't know 
> this rule. I'll modify Signed-off-by. Thank you for your comment.

Oh. I wasn't really thinking you _need_ to change it - actually I was
wondering if you _want_ to change it since I thought maybe "Zheng tan"
was your preferred spelling, and your email client just used the
localpart (before the @) instead of your name spelled out by accident.

So either way I'm fine. Let me know what you prefer.

johannes

Re: [PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[tanzheng]

> > > > There is no need to call wiphy_dev again.Simplifying the
> > > > code makes it more readable.
> > > > 
> > > > Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
> > > > 
> > > 
> > > The bot complains this doesn't match your From: line, is that
> > intentional?
> > 
> > Yes, I set it up this way on purpose. Sorry, I don't know 
> > this rule. I'll modify Signed-off-by. Thank you for your comment.
>
> Oh. I wasn't really thinking you _need_ to change it - actually I was
> wondering if you _want_ to change it since I thought maybe "Zheng tan"
> was your preferred spelling, and your email client just used the
> localpart (before the @) instead of your name spelled out by accident.
> 
> So either way I'm fine. Let me know what you prefer.

In that case, perhaps I prefer "Zheng tan".

Best regards,
Zheng tan

Re: [PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[Johannes Berg]

On Tue, 2025-09-09 at 09:14 +0800, tanzheng wrote:
> > > > > There is no need to call wiphy_dev again.Simplifying the
> > > > > code makes it more readable.
> > > > > 
> > > > > Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
> > > > > 
> > > > 
> > > > The bot complains this doesn't match your From: line, is that
> > > intentional?
> > > 
> > > Yes, I set it up this way on purpose. Sorry, I don't know 
> > > this rule. I'll modify Signed-off-by. Thank you for your comment.
> > 
> > Oh. I wasn't really thinking you _need_ to change it - actually I was
> > wondering if you _want_ to change it since I thought maybe "Zheng tan"
> > was your preferred spelling, and your email client just used the
> > localpart (before the @) instead of your name spelled out by accident.
> > 
> > So either way I'm fine. Let me know what you prefer.
> 
> In that case, perhaps I prefer "Zheng tan".

Ideally you could resend with your From: line adjusted, or even an extra
From: line thrown into the body of the mail, but I suppose I can try to
adjust the From: line as well on the other mail you sent, assuming I
remember :)

johannes

Re: [PATCH v3] wifi: cfg80211: Remove the redundant wiphy_dev

[Zheng tan]

> > > > > > There is no need to call wiphy_dev again.Simplifying the
> > > > > > code makes it more readable.
> > > > > > 
> > > > > > Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
> > > > > > 
> > > > > 
> > > > > The bot complains this doesn't match your From: line, is that
> > > > intentional?
> > > > 
> > > > Yes, I set it up this way on purpose. Sorry, I don't know 
> > > > this rule. I'll modify Signed-off-by. Thank you for your comment.
> > > 
> > > Oh. I wasn't really thinking you _need_ to change it - actually I was
> > > wondering if you _want_ to change it since I thought maybe "Zheng tan"
> > > was your preferred spelling, and your email client just used the
> > > localpart (before the @) instead of your name spelled out by accident.
> > > 
> > > So either way I'm fine. Let me know what you prefer.
> > 
> > In that case, perhaps I prefer "Zheng tan".
> 
> Ideally you could resend with your From: line adjusted, or even an extra
> From: line thrown into the body of the mail, but I suppose I can try to
> adjust the From: line as well on the other mail you sent, assuming I
> remember :)

I will adjust the From line of the patch and resend it. Thank you for your 
patient reply!

Best regards,
Zheng tan