From: Arnd Bergmann <arnd@arndb.de>
To: zengtao <prime.zeng@huawei.com>
Cc: tglx@linutronix.de, fweisbec@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cputime: Fix timeval/timespec-->cputime conversion
Date: Tue, 02 Feb 2016 13:53:01 +0100 [thread overview]
Message-ID: <2375212.i4Z9u5Ytcc@wuerfel> (raw)
In-Reply-To: <1454384314-154784-1-git-send-email-prime.zeng@huawei.com>
On Tuesday 02 February 2016 11:38:34 zengtao wrote:
> The datatype __kernel_time_t is u32 on 32bit platform,
> it will easily get overflow, so force u64 conversion.
>
> Currently the following function will be affected:
> 1. setitimer()
> 2. timer_create/timer_settime()
> 3. sys_clock_nanosleep
> And this will occur on MIPS32 and ARM32 with "Full dynticks CPU
> time accounting" enabled, which is required for CONFIG_NO_HZ_FULL.
>
> Signed-off-by: zengtao <prime.zeng@huawei.com>
>
The patch looks good now, but please add a line saying
Fixes: 31c1fc818715 ("ARM: Kconfig: allow full nohz CPU accounting")
below your Signed-off-by, so everyone can figure out whether they
need this backported or not.
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Thomas, do you want to take this through the tip tree?
next prev parent reply other threads:[~2016-02-02 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 3:38 zengtao
2016-02-02 12:53 ` Arnd Bergmann [this message]
2016-02-02 14:30 ` [tip:timers/urgent] cputime: Prevent 32bit overflow in time[ val|spec]_to_cputime() tip-bot for zengtao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375212.i4Z9u5Ytcc@wuerfel \
--to=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prime.zeng@huawei.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®