Re: [patch] Makefile: can't build modules outside the kernel tree if it was built using O=

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Caveh Jalali <ecaveh@gmail.com>
Cc: sam@ravnborg.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] Makefile: can't build modules outside the kernel tree if  it was built using O=
Date: Thu, 17 Sep 2009 11:15:53 +0800	[thread overview]
Message-ID: <2375c9f90909162015h39aeee14s99d3173d0a9baf7c@mail.gmail.com> (raw)
In-Reply-To: <830a8fa70909161930r518a9644ja954ced2ae5814b4@mail.gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 2150 bytes --]

On Thu, Sep 17, 2009 at 10:30 AM, Caveh Jalali <ecaveh@gmail.com> wrote:> in 2.6.31, it is no longer possible to build kernel modules for some platforms> (the ones that need include2) outside the kernel src tree if the> src tree was built using O= to specify an alternate directory for the> build output.>> i think this broke with the following commit:>> commit b8b572e1015f81b4e748417be2629dfe51ab99f9> Author: Stephen Rothwell <sfr@canb.auug.org.au>> Date:Â Â  Fri Aug 1 15:20:30 2008 +1000

Only after 2.6.31? This commit was on 2008 Aug 1...
>> Â Â  powerpc: Move include files to arch/powerpc/include/asm>>> when the platform specific include directories were shuffled around> without updating the> top level Makefile. Â however, i think this FAIL is generic, and not> limited to powerpc.> here's a patch to the top level Makefile to teach it about the shuffled files:>

You forgot your SOB line.
Anyway, it looks fine.
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>> --- /local/caveh/linux/linux-2.6.31/MakefileÂ Â Â  2009-09-09> 15:13:59.000000000 -0700> +++ MakefileÂ Â Â  2009-09-16 12:23:05.000000000 -0700> @@ -958,9 +958,9 @@ ifneq ($(KBUILD_SRC),)> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  echo "Â  in the '$(srctree)' directory.";\> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  /bin/false; \> Â Â Â Â Â Â Â  fi;> -Â Â Â Â Â Â  $(Q)if [ ! -d include2 ]; thenÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  \> -Â Â Â Â Â Â Â Â Â Â  mkdir -p include2;Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  \> -Â Â Â Â Â Â Â Â Â Â  ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm;Â Â Â Â  \> +Â Â Â Â Â Â  $(Q)if [ ! -d include2 ]; thenÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  \> +Â Â Â Â Â Â Â Â Â Â  mkdir -p include2;Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  \> +Â Â Â Â Â Â Â Â Â Â  ln -fsn $(srctree)/arch/$(SRCARCH)/include/asm include2/asm; \> Â Â Â Â Â Â Â  fi> Â endifÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

next prev parent reply	other threads:[~2009-09-17  3:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  2:30 Caveh Jalali
2009-09-17  3:15 ` Américo Wang [this message]
2009-09-17  4:40 ` Caveh Jalali
2009-09-17 11:45 ` Arnd Bergmann
2009-09-17 21:49   ` Caveh Jalali
2009-09-18  9:28     ` Arnd Bergmann
2009-09-18 11:15     ` Arnd Bergmann
2009-09-18  1:49   ` Américo Wang
2009-09-18  4:52     ` Sam Ravnborg
2009-09-21 14:37       ` [PATCH] warn about use of uninstalled kernel headers Arnd Bergmann
2009-09-22  4:43         ` Sam Ravnborg
2009-09-22 13:09           ` Arnd Bergmann
2009-09-27  8:44         ` Sam Ravnborg
2009-09-19  9:06 ` [patch] Makefile: can't build modules outside the kernel tree if it was built using O= Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2375c9f90909162015h39aeee14s99d3173d0a9baf7c@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=ecaveh@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®