Re: [PATCH] module: Fix up CONFIG_KALLSYMS=n build.

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Fri, Sep 25, 2009 at 11:45 AM, Paul Mundt <lethal@linux-sh.org> wrote:
> Starting from commit 4a4962263f07d14660849ec134ee42b63e95ea9a
> "reduce symbol table for loaded modules (v2)", the kernel/module.c build
> is broken with CONFIG_KALLSYMS disabled.
>
>  CC      kernel/module.o
> kernel/module.c:1995: warning: type defaults to 'int' in declaration of 'Elf_Hdr'
> kernel/module.c:1995: error: expected ';', ',' or ')' before '*' token
> kernel/module.c: In function 'load_module':
> kernel/module.c:2203: error: 'strmap' undeclared (first use in this function)
> kernel/module.c:2203: error: (Each undeclared identifier is reported only once
> kernel/module.c:2203: error: for each function it appears in.)
> kernel/module.c:2239: error: 'symoffs' undeclared (first use in this function)
> kernel/module.c:2239: error: implicit declaration of function 'layout_symtab'
> kernel/module.c:2240: error: 'stroffs' undeclared (first use in this function)
> make[1]: *** [kernel/module.o] Error 1
> make: *** [kernel/module.o] Error 2
>
> There are three different issues:
>
>    - layout_symtab() takes a const Elf_Ehdr
>
>    - layout_symtab() needs to return a value
>
>    - symoffs/stroffs/strmap are referenced by the load_module() code
>      despite being ifdefed out, which seems unnecessary given the noop
>      behaviour of layout_symtab()/add_kallsyms() in the case of
>      CONFIG_KALLSYMS=n.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Jan Beulich <jbeulich@novell.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>

Indeed.

Acked-by: WANG Cong <amwang@redhat.com>