From: "Jan Beulich" <JBeulich@novell.com>
To: "Paul Mundt" <lethal@linux-sh.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Rusty Russell" <rusty@rustcorp.com.au>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: Fix up CONFIG_KALLSYMS=n build.
Date: Fri, 25 Sep 2009 07:42:08 +0100 [thread overview]
Message-ID: <4ABC82600200007800016C5C@vpn.id2.novell.com> (raw)
In-Reply-To: <20090925034557.GA12810@linux-sh.org>
>>> Paul Mundt <lethal@linux-sh.org> 25.09.09 05:45 >>>
>There are three different issues:
>
> - layout_symtab() takes a const Elf_Ehdr
>
> - layout_symtab() needs to return a value
>
> - symoffs/stroffs/strmap are referenced by the load_module() code
> despite being ifdefed out, which seems unnecessary given the noop
> behaviour of layout_symtab()/add_kallsyms() in the case of
> CONFIG_KALLSYMS=n.
>
>Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Oh, sorry for not having checked that. Thanks, and
Acked-by: Jan Beulich <jbeulich@novell.com>
next prev parent reply other threads:[~2009-09-25 6:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 3:45 Paul Mundt
2009-09-25 6:42 ` Jan Beulich [this message]
2009-09-25 6:49 ` Américo Wang
2009-09-25 7:54 ` Rusty Russell
2009-09-25 8:14 ` Sam Ravnborg
2009-09-27 7:03 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABC82600200007800016C5C@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®