mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	paul.arola@telus.com, scott.roberts@telus.com,
	"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: enable support for 88E6361 switch
Date: Mon, 22 May 2023 14:19:38 +0200	[thread overview]
Message-ID: <237dbb7f-8979-4435-a099-95bb5d093910@lunn.ch> (raw)
In-Reply-To: <1c104034-b61f-5242-40fa-339de59ac9c9@bootlin.com>

> > Not exactly related to this patch, but please do not rely on this "max
> > speed mode" - please always ensure that you specify the phy-mode and
> > fixed-link settings for CPU and DSA ports in firmware. Thanks.
> 
> I would like to make sure to fully understand your point:
> - when telling so specify phy-mode and fixed-link in firmware, you mean
> device-tree, right ?
> - when checking for code and execution flow, I observe that port_max_speed is
> always called and its output is always used to configure shared ports mode in
> mv88e6xxx driver. Are you telling that eventually, the whole mv88e6xxx driver
> should stop relying on port_max_speed_mode for shared ports ?

Yes, the concept of port_max_speed_mode causes problems for PHYLINK,
and we want to remove it. Russell and i have been updating DT
descriptions adding fixed-link and phy-mode properties to all
mv88e6xxx systems so that it is not needed. Either at the end of this
cycle, or the beginning of the next we will change the code to
actually enforce this.

	 Andrew

  reply	other threads:[~2023-05-22 12:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 14:12 [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: add 88E6361 support alexis.lothore
2023-05-19 14:12 ` [PATCH net-next v2 1/7] dt-bindings: net: dsa: marvell: add MV88E6361 switch to compatibility list alexis.lothore
2023-05-20  2:54   ` Florian Fainelli
2023-05-19 14:12 ` [PATCH net-next v2 2/7] net: dsa: mv88e6xxx: pass directly chip structure to mv88e6xxx_phy_is_internal alexis.lothore
2023-05-19 14:36   ` Russell King (Oracle)
2023-05-20  2:54   ` Florian Fainelli
2023-05-19 14:12 ` [PATCH net-next v2 3/7] net: dsa: mv88e6xxx: use mv88e6xxx_phy_is_internal in mv88e6xxx_port_ppu_updates alexis.lothore
2023-05-19 14:37   ` Russell King (Oracle)
2023-05-20  2:54   ` Florian Fainelli
2023-05-19 14:13 ` [PATCH net-next v2 4/7] net: dsa: mv88e6xxx: add field to specify internal phys layout alexis.lothore
2023-05-19 16:11   ` Andrew Lunn
2023-05-19 14:13 ` [PATCH net-next v2 5/7] net: dsa: mv88e6xxx: fix 88E6393X family " alexis.lothore
2023-05-19 16:12   ` Andrew Lunn
2023-05-20  2:55   ` Florian Fainelli
2023-05-19 14:13 ` [PATCH net-next v2 6/7] net: dsa: mv88e6xxx: pass mv88e6xxx_chip structure to port_max_speed_mode alexis.lothore
2023-05-20  2:56   ` Florian Fainelli
2023-05-19 14:13 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: enable support for 88E6361 switch alexis.lothore
2023-05-19 14:43   ` Russell King (Oracle)
2023-05-22  8:15     ` Alexis Lothoré
2023-05-22 12:19       ` Andrew Lunn [this message]
2023-05-22 12:26         ` Alexis Lothoré
2023-05-19 16:21   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237dbb7f-8979-4435-a099-95bb5d093910@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexis.lothore@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kabel@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=paul.arola@telus.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=scott.roberts@telus.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®