mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Alison Schofield <alison.schofield@intel.com>,
	Gregory Price <gourry@gourry.net>
Cc: Vishal Aslot <vaslot@nvidia.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Li Ming <ming.li@zohomail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"open list:COMPUTE EXPRESS LINK (CXL)"
	<linux-cxl@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] cxl_test: enable zero sized decoders under hb0
Date: Mon, 20 Oct 2025 14:22:36 -0700	[thread overview]
Message-ID: <2393460e-aed6-44ac-9f11-f5b9a1f29e6b@intel.com> (raw)
In-Reply-To: <aPaNzeGqUHf6gGIu@aschofie-mobl2.lan>



On 10/20/25 12:30 PM, Alison Schofield wrote:
> On Mon, Oct 20, 2025 at 10:19:09AM -0400, Gregory Price wrote:
>> On Mon, Oct 20, 2025 at 12:09:34AM -0700, Alison Schofield wrote:
>>>> This patch updates cxl_test to enable decoders 1 and 2
>>>> in the host-bridge 0 port, in a switch uport under hb0,
>>>> and the endpoints ports with size zero simulating
>>>> committed zero sized decoders.
>>>
>>> Decoders 1 & 2 - those are after decoder 0, the autoregion.
>>> That's a problem ATM, when we try to teardown the autoregion we
>>> get out of order resets. Like I asked in the other patch, if there
>>> are rules about where these zero size decoders may appear, that
>>> may make the solution here simpler.
>>>
>>
>> I think this is going to require a quirk-doc like other deviations.
> 
> Really need to hear more about spec here. You mention quirk, but is it
> really a quirk or spec defined behavior?
> 
>>
>> A committed decoder must have a base address, and with 0-size subsequent
>> or previous decoders would also have an address that covers that address
>> as well.  This is on top of the ordering issue if the 0-side decoders
>> come after a programmable decoder.
>>
>> I'm not convinced this even makes sense as a security thing if you can
>> reset the bus and re-activate everything (after a graceful teardown).
>>
>> Seems easier to just report the decoders as unavailable and then not
>> probe them.
> 
> Users see a memdev in the topology and want to use it but find no
> available endpoint decoder. We'll probably want a mechanism to show why
> that is so, hence the suggestion to add to topology and show as locked.

I think the kernel driver should be fully aware of what is and isn't fully present and handle them appropriately. And on the user side, 'cxl list' should show a decoder in a zero size state so the admin knows why things are the way they are.  > 
>>
>> ~Gregory


  reply	other threads:[~2025-10-20 21:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  2:40 [PATCH v1 0/2] Support zero-sized decoders Vishal Aslot
2025-10-15  2:40 ` [PATCH v1 1/2] cxl_test: enable zero sized decoders under hb0 Vishal Aslot
2025-10-15 15:38   ` Dave Jiang
2025-10-20  7:09   ` Alison Schofield
2025-10-20 14:19     ` Gregory Price
2025-10-20 19:30       ` Alison Schofield
2025-10-20 21:22         ` Dave Jiang [this message]
2025-10-21 14:03         ` Gregory Price
2026-02-11 15:04           ` Gregory Price
2026-02-11 15:59             ` Gregory Price
2026-05-08  4:00               ` Richard Cheng
2025-10-15  2:40 ` [PATCH v1 2/2] cxl: Allow zero sized HDM decoders Vishal Aslot
2025-10-15 16:38   ` Dave Jiang
2025-10-20  6:46   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2393460e-aed6-44ac-9f11-f5b9a1f29e6b@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave@stgolabs.net \
    --cc=gourry@gourry.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=peterz@infradead.org \
    --cc=vaslot@nvidia.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®