mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Vishal Aslot <vaslot@nvidia.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Li Ming <ming.li@zohomail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"open list:COMPUTE EXPRESS LINK (CXL)"
	<linux-cxl@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] cxl_test: enable zero sized decoders under hb0
Date: Wed, 11 Feb 2026 10:59:22 -0500	[thread overview]
Message-ID: <aYynWqJ7u-v-6WsZ@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <aYyaicFMzfsd8eSq@gourry-fedora-PF4VCD3F>

On Wed, Feb 11, 2026 at 10:04:41AM -0500, Gregory Price wrote:
> Revisiting this - it might be reasonable to allow post-lock ordering if
> *all* decoders in beyond the programmable one are zero-locked.
> 
> Seems ok? Thoughts?
> 

Sorry, got myself a bit mixed up, lets me a bit more precise, there are
annoying corner conditions here that make reasoning about this
difficult, and the mild ambiguity in the spec doesn't imbue confidence.

[open] = programmable
[programmed] = usually auto-decoder, but some cases may allow runtime
               programming, i haven't logic'd that out.


                    Post-lock   Legal
decoder        0             1             2     ...     N
------------------------------------------------------------------
            [open]       [zero-lock]  [zero-lock]   [zero-lock]
	    [open]         [open]     [zero-lock]   [zero-lock]
	  [programmed]     [open]     [zero-lock]   [zero-lock]
	  [programmed]  [programmed]  [zero-lock]   [zero-lock]


In these cases you basically act as-if the zero-locked decoders
essentially don't exist.



                   Pre-lock    Legal
decoder        0             1             2     ...     N
------------------------------------------------------------------
	  [zero-lock]    [zero-lock]  [zero-lock]      [open]
	  [zero-lock]    [zero-lock]  [zero-lock]    [programmed]
	  [zero-lock]    [zero-lock]  [programmed]     [open]
	  [zero-lock]    [zero-lock]  [programmed]   [programmed]

Again, in these causes you just act like the decoders don't exist.


                           Illegal
decoder        0              1             2      ...     N
------------------------------------------------------------------
            [open]       [zero-lock]      [open]      [zero-lock]
          [programmed]   [zero-lock]      [open]      [zero-lock]
            [open]       [zero-lock]   [programmed]   [zero-lock]
          [zero-lock]       [open]      [zero-lock]   [zero-lock]
          [zero-lock]       [open]      [zero-lock]     [open]
          [zero-lock]       [open]      [zero-lock]     [open]
          [zero-lock]       [open]      [zero-lock]   [programmed]

These cases are all illegal because there is always some form of
decoder committed out-of-order in the presence of at least one locked
decoder (the zero-locks).


                           Questionable
decoder        0              1             2      ...     N
------------------------------------------------------------------
	  [zero-lock]    [programmed]   [zero-lock]    [zero-lock]
          [programmed]   [zero-lock]    [programmed]   [zero-lock]
	  [zero-lock]    [programmed]   [zero-lock]    [programmed]
******    [zero-lock]    [programmed]   [zero-lock]  [open]...[open]


In these cases, it's only really legal IFF the programmed decoder(s) are
auto-decoders, because it means an out-of-order condition is impossible.

I think you can validate this on probe, but it's annoying

if zero-lock decoder is present
	a) all decoders prior to the zero-lock are locked (zero | auto)
	b) all decoders after the zero-lock are locked*

* if an open decoder appears after a zero-lock, all decoders after
  the open decoder must also be open. (supports corner case above)


I... think that works?  It's annoying though lol.

~Gregory

  reply	other threads:[~2026-02-11 15:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  2:40 [PATCH v1 0/2] Support zero-sized decoders Vishal Aslot
2025-10-15  2:40 ` [PATCH v1 1/2] cxl_test: enable zero sized decoders under hb0 Vishal Aslot
2025-10-15 15:38   ` Dave Jiang
2025-10-20  7:09   ` Alison Schofield
2025-10-20 14:19     ` Gregory Price
2025-10-20 19:30       ` Alison Schofield
2025-10-20 21:22         ` Dave Jiang
2025-10-21 14:03         ` Gregory Price
2026-02-11 15:04           ` Gregory Price
2026-02-11 15:59             ` Gregory Price [this message]
2026-05-08  4:00               ` Richard Cheng
2025-10-15  2:40 ` [PATCH v1 2/2] cxl: Allow zero sized HDM decoders Vishal Aslot
2025-10-15 16:38   ` Dave Jiang
2025-10-20  6:46   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYynWqJ7u-v-6WsZ@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=peterz@infradead.org \
    --cc=vaslot@nvidia.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®