From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
hannes@cmpxchg.org, mkoutny@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 27/40] sched/deadline: Move a task's bandwidth to the root domain it runs in
Date: Wed, 18 Nov 2026 08:40:09 -0500 [thread overview]
Message-ID: <239ea541-da99-4fb3-b144-b145640152ef@efficios.com> (raw)
In-Reply-To: <sashiko-outbox-219077@kernel.org>
> Can dl_task_move_bw() move the departing bandwidth of a non-deadline
> task that was PI-boosted back into the deadline class?
Yes, and this is intended. A departed task boosted back is in the class.
A rebuild counts it where it runs, like any deadline task (see
switched_to_dl()). The move does the same thing at the wakeup.
The bandwidth is moved, not released. One root domain counts it at any
time. If the boost ends before the 0-lag time, the task goes back on the
departed list with the new record. Its inactive timer then releases the
bandwidth there. The move has no check for room. That is a known limit,
which the cover letter lists for this patch. This was checked by
reading.
> Does skipping dl_task_move_bw() when p->is_blocked &&
> task_on_rq_migrating(p) also drop the bandwidth move for normal
> queued migrations of mutex-blocked tasks under
> CONFIG_SCHED_PROXY_EXEC?
Yes, thanks. On this base, proxy_set_task_cpu() does not call
migrate_task_rq_dl(). So the check guarded no proxy migration. It only
skipped the ordinary migrations of a blocked task.
With admission control on, I found no such migration that crosses root
domains. sched_setaffinity() must keep the span, patch 28 keeps the task
in it, and a cpuset attach moves the bandwidth itself. With admission
control off, sched_setaffinity() can cross. The bandwidth then stays
behind until the task sleeps and wakes, or migrates again.
The next version removes the check. It stays in the proxy execution RFC,
in the patch that makes a proxy migration call migrate_task_rq(). That
series also wakes a blocked deadline task through the full path, which
moves the bandwidth. This was checked by reading, not reproduced.
> Can keeping dl_bw_rebuilding() true until the end of the tasklist
> walk drop bandwidth moves for tasks that dl_add_task_root_domain()
> has already visited?
Yes. The message says the rebuild that follows counts the task. That
holds only for a task the walk has not reached yet.
The root domains are final once the walk starts. So the next version
ends the rebuild window in dl_clear_root_domains(). A flag,
dl_bw_walking, then covers the walk of the task list. A helper,
dl_bw_move_blocked(p), blocks a move in two cases:
- the sched domains are being rebuilt;
- the walk runs and has not counted p yet (p has an old dl_bw_gen).
The walk then counts p where it is. A task the walk already counted
moves its bandwidth again. The walk and a wakeup both hold the pi_lock
of the task, so they are ordered.
This moves the boundary of the known limit of patch 28. A wakeup can
pick its CPU before the walk reaches the task, and be queued after the
walk counted it. Its bandwidth then moves with no check for room. The
cover letter and the message of patch 28 state this.
> In addition, when dl_task_bw_elsewhere() runs under rq->__lock
> without p->pi_lock, it reads bw_cpu = READ_ONCE(p->dl.dl_bw_cpu)
> before checking dl_bw_rebuilding() and READ_ONCE(dl_bw_gen)
That lockless test is only a hint. dl_task_move_bw() reads the record
again under dl_departed_lock. A stale read can only skip a move. The
next wakeup or migration tests again. I left it.
Both points were checked by reading. Neither was reproduced.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2026-11-18 13:40 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:10 [PATCH v7 00/40] sched/deadline: bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 01/40] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 02/40] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 03/40] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 04/40] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-18 11:20 ` Juri Lelli
2026-11-17 14:10 ` [PATCH v7 05/40] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-17 14:38 ` sashiko-bot
2026-11-18 13:31 ` Mathieu Desnoyers
2026-11-18 11:26 ` Juri Lelli
2026-11-18 13:45 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 06/40] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 07/40] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 08/40] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-18 13:15 ` Juri Lelli
2026-11-18 13:44 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 09/40] rtmutex: Continue the chain walk when a waiter's deadline donor changes Mathieu Desnoyers
2026-11-17 14:50 ` sashiko-bot
2026-11-18 13:35 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 10/40] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-17 14:55 ` sashiko-bot
2026-11-18 13:34 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 11/40] sched/deadline: Reset the donor's runtime at a deboost in the class Mathieu Desnoyers
2026-11-17 14:55 ` sashiko-bot
2026-11-18 13:36 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 12/40] sched/deadline: Replenish a throttled task boosted while asleep Mathieu Desnoyers
2026-11-17 14:55 ` sashiko-bot
2026-11-18 13:36 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 13/40] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 14/40] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 15/40] sched/deadline: Keep departing bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 16/40] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 17/40] sched/deadline: Rebuild the root domains' accounting from the task list Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 18/40] sched/deadline: Record the root domain holding a task's bandwidth Mathieu Desnoyers
2026-11-17 15:14 ` sashiko-bot
2026-11-18 13:37 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 19/40] sched/deadline: Leave a dying task out of a rebuild of the accounting Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 20/40] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 21/40] sched/deadline: Move a task's bandwidth only where room was made Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 22/40] cgroup/cpuset: Wait for an attach before rebuilding the sched domains Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 23/40] sched: Make deadline policy and affinity changes wait for a cpuset attach Mathieu Desnoyers
2026-11-17 15:18 ` sashiko-bot
2026-11-18 13:38 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 24/40] cgroup/cpuset: Give back the bandwidth an attach did not move Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 25/40] cgroup/cpuset: Reserve the bandwidth in the root domain a task moves to Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 26/40] sched/deadline: Make a rebuild count a task in the root domain it runs in Mathieu Desnoyers
2026-11-17 15:31 ` sashiko-bot
2026-11-18 13:39 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 27/40] sched/deadline: Move a task's bandwidth to " Mathieu Desnoyers
2026-11-17 15:29 ` sashiko-bot
2026-11-18 13:40 ` Mathieu Desnoyers [this message]
2026-11-17 14:10 ` [PATCH v7 28/40] sched/deadline: Keep a task in the root domain that counts its bandwidth Mathieu Desnoyers
2026-11-17 15:32 ` sashiko-bot
2026-11-18 13:40 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 29/40] sched/deadline: Keep the last CPU a task has in its root domain Mathieu Desnoyers
2026-11-17 15:41 ` sashiko-bot
2026-11-18 13:41 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 30/40] cgroup/cpuset: Refuse to take a deadline task out of " Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 31/40] sched/deadline: Cancel the replenishment timer with the parameters Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 32/40] sched/deadline: Count the bandwidth a boosted task is given Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 33/40] sched/deadline: Start a period for a task that enters the class blocked Mathieu Desnoyers
2026-11-17 15:46 ` sashiko-bot
2026-11-18 13:42 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 34/40] sched/deadline: Cap the runtime left of a constrained task at dl_runtime Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 35/40] sched/deadline: Check the runtime of a task that comes back runnable Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 36/40] sched/deadline: Check the runtime of a task whose parameters change Mathieu Desnoyers
2026-11-17 15:45 ` sashiko-bot
2026-11-18 13:42 ` Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 37/40] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-17 14:10 ` [PATCH v7 38/40] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-17 15:23 ` sashiko-bot
2026-11-18 13:43 ` Mathieu Desnoyers
2026-11-17 14:11 ` [PATCH v7 39/40] selftests/sched: Test SCHED_DEADLINE bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-17 14:11 ` [PATCH v7 40/40] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239ea541-da99-4fb3-b144-b145640152ef@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mkoutny@suse.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®