* [PATCH] erofs: fix memleak of node's shared xattr array
@ 2019-02-14 9:37 Sheng Yong
2019-02-14 1:53 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Sheng Yong @ 2019-02-14 9:37 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel, chao
If it fails to read a shared xattr page, the node's shared xattr array
is not freed. The next time the node's xattr is accessed, the previously
allocated array is leaked.
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
drivers/staging/erofs/xattr.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index 80dca6a4adbe..e3f8b904a680 100644
--- a/drivers/staging/erofs/xattr.c
+++ b/drivers/staging/erofs/xattr.c
@@ -92,8 +92,11 @@ static int init_inode_xattrs(struct inode *inode)
it.page = erofs_get_meta_page(sb,
++it.blkaddr, S_ISDIR(inode->i_mode));
- if (IS_ERR(it.page))
+ if (IS_ERR(it.page)) {
+ kfree(vi->xattr_shared_xattrs);
+ vi->xattr_shared_xattrs = NULL;
return PTR_ERR(it.page);
+ }
it.kaddr = kmap_atomic(it.page);
atomic_map = true;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] erofs: fix memleak of node's shared xattr array
2019-02-14 9:37 [PATCH] erofs: fix memleak of node's shared xattr array Sheng Yong
@ 2019-02-14 1:53 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2019-02-14 1:53 UTC (permalink / raw)
To: Sheng Yong; +Cc: yuchao0, gregkh, linux-erofs, devel, linux-kernel, chao
Hi Sheng,
On 2019/2/14 17:37, Sheng Yong wrote:
> If it fails to read a shared xattr page, the node's shared xattr array
node -> inode since erofs doesn't have 'node' concept like f2fs...
> is not freed. The next time the node's xattr is accessed, the previously
> allocated array is leaked.
>
Good catch! I think it's a valid object memory leak.
the subject should be fixed as [PATCH] staging: erofs: fix memleak of inode's shared xattr array
^
Thanks,
Gao Xiang
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
> ---
> drivers/staging/erofs/xattr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
> index 80dca6a4adbe..e3f8b904a680 100644
> --- a/drivers/staging/erofs/xattr.c
> +++ b/drivers/staging/erofs/xattr.c
> @@ -92,8 +92,11 @@ static int init_inode_xattrs(struct inode *inode)
>
> it.page = erofs_get_meta_page(sb,
> ++it.blkaddr, S_ISDIR(inode->i_mode));
> - if (IS_ERR(it.page))
> + if (IS_ERR(it.page)) {
> + kfree(vi->xattr_shared_xattrs);
> + vi->xattr_shared_xattrs = NULL;
> return PTR_ERR(it.page);
> + }
>
> it.kaddr = kmap_atomic(it.page);
> atomic_map = true;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-14 1:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 9:37 [PATCH] erofs: fix memleak of node's shared xattr array Sheng Yong
2019-02-14 1:53 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®