* [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value
@ 2022-04-22 10:41 Krzysztof Kozlowski
2022-04-22 16:22 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 10:41 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Neil Armstrong, linux-kernel,
linux-arm-kernel, linux-oxnas
Cc: Krzysztof Kozlowski
The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/clocksource/timer-oxnas-rps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-oxnas-rps.c b/drivers/clocksource/timer-oxnas-rps.c
index 56c0cc32d0ac..d514b44e67dd 100644
--- a/drivers/clocksource/timer-oxnas-rps.c
+++ b/drivers/clocksource/timer-oxnas-rps.c
@@ -236,7 +236,7 @@ static int __init oxnas_rps_timer_init(struct device_node *np)
}
rps->irq = irq_of_parse_and_map(np, 0);
- if (rps->irq < 0) {
+ if (!rps->irq) {
ret = -EINVAL;
goto err_iomap;
}
--
2.32.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value
2022-04-22 10:41 [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
@ 2022-04-22 16:22 ` Neil Armstrong
2022-05-20 14:52 ` Krzysztof Kozlowski
2022-05-27 8:35 ` [tip: timers/core] " tip-bot2 for Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2022-04-22 16:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Daniel Lezcano, Thomas Gleixner,
linux-kernel, linux-arm-kernel, linux-oxnas
On 22/04/2022 12:41, Krzysztof Kozlowski wrote:
> The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
>
> Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/clocksource/timer-oxnas-rps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-oxnas-rps.c b/drivers/clocksource/timer-oxnas-rps.c
> index 56c0cc32d0ac..d514b44e67dd 100644
> --- a/drivers/clocksource/timer-oxnas-rps.c
> +++ b/drivers/clocksource/timer-oxnas-rps.c
> @@ -236,7 +236,7 @@ static int __init oxnas_rps_timer_init(struct device_node *np)
> }
>
> rps->irq = irq_of_parse_and_map(np, 0);
> - if (rps->irq < 0) {
> + if (!rps->irq) {
> ret = -EINVAL;
> goto err_iomap;
> }
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value
2022-04-22 10:41 [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
2022-04-22 16:22 ` Neil Armstrong
@ 2022-05-20 14:52 ` Krzysztof Kozlowski
2022-05-20 15:24 ` Daniel Lezcano
2022-05-27 8:35 ` [tip: timers/core] " tip-bot2 for Krzysztof Kozlowski
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-20 14:52 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Neil Armstrong, linux-kernel,
linux-arm-kernel, linux-oxnas
On 22/04/2022 12:41, Krzysztof Kozlowski wrote:
> The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
>
> Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This was sent a month ago and it is a fix. It also received a review.
Any comments from maintainers? Is it going to be picked up?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* [tip: timers/core] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value
2022-04-22 10:41 [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
2022-04-22 16:22 ` Neil Armstrong
2022-05-20 14:52 ` Krzysztof Kozlowski
@ 2022-05-27 8:35 ` tip-bot2 for Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Krzysztof Kozlowski @ 2022-05-27 8:35 UTC (permalink / raw)
To: linux-tip-commits
Cc: Krzysztof Kozlowski, Neil Armstrong, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 9c04a8ff03def4df3f81219ffbe1ec9b44ff5348
Gitweb: https://git.kernel.org/tip/9c04a8ff03def4df3f81219ffbe1ec9b44ff5348
Author: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
AuthorDate: Fri, 22 Apr 2022 12:41:01 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 24 May 2022 09:16:29 +02:00
clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value
The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20220422104101.55754-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/timer-oxnas-rps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-oxnas-rps.c b/drivers/clocksource/timer-oxnas-rps.c
index 56c0cc3..d514b44 100644
--- a/drivers/clocksource/timer-oxnas-rps.c
+++ b/drivers/clocksource/timer-oxnas-rps.c
@@ -236,7 +236,7 @@ static int __init oxnas_rps_timer_init(struct device_node *np)
}
rps->irq = irq_of_parse_and_map(np, 0);
- if (rps->irq < 0) {
+ if (!rps->irq) {
ret = -EINVAL;
goto err_iomap;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-27 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 10:41 [PATCH] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
2022-04-22 16:22 ` Neil Armstrong
2022-05-20 14:52 ` Krzysztof Kozlowski
2022-05-20 15:24 ` Daniel Lezcano
2022-05-27 8:35 ` [tip: timers/core] " tip-bot2 for Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®