From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [REGRESSION] omapdrm/N900 display broken
Date: Fri, 27 Nov 2020 20:44:23 +0200 [thread overview]
Message-ID: <23e27b7a-d2b9-a0c0-7518-bb5105306a97@gmail.com> (raw)
In-Reply-To: <a86e0ef4-0b90-5aec-9632-e78fa4ca6d58@ti.com>
Hi,
On 27.11.20 г. 19:30 ч., Tomi Valkeinen wrote:
> On 27/11/2020 17:37, Ivaylo Dimitrov wrote:
>
>> With 5.9.11 and the patch on top, n900 boots fine, albeit display remains blank, could be related to
>> brightness, we're still investigating.
>
> Ok. A DSS regdump for a working version and the latest one would be good too. There's a omapdss
> debugfs dir, with dss, dispc and clk files which are of interest here.
>
It turned out to be a long standing bug in the panel driver, with the
bellow fix it works fine:
diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
index fc6a7e451abe..304267f7849a
--- a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
+++ b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
@@ -629,7 +629,7 @@ static int acx565akm_probe(struct spi_device *spi)
lcd->spi = spi;
mutex_init(&lcd->mutex);
- lcd->reset_gpio = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_LOW);
+ lcd->reset_gpio = devm_gpiod_get(&spi->dev, "reset",
GPIOD_OUT_HIGH);
if (IS_ERR(lcd->reset_gpio)) {
dev_err(&spi->dev, "failed to get reset GPIO\n");
return PTR_ERR(lcd->reset_gpio);
Proper patch will follow.
Thanks,
Ivo
next prev parent reply other threads:[~2020-11-27 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 18:14 Aaro Koskinen
2020-08-04 12:13 ` Tomi Valkeinen
2020-08-04 12:39 ` Tomi Valkeinen
2020-08-23 16:26 ` Aaro Koskinen
2020-08-25 13:16 ` Tomi Valkeinen
2020-11-24 21:03 ` Ivaylo Dimitrov
2020-11-26 14:11 ` Tomi Valkeinen
2020-11-26 23:17 ` Ivaylo Dimitrov
2020-11-27 11:45 ` Tomi Valkeinen
2020-11-27 13:10 ` Ivaylo Dimitrov
2020-11-27 15:37 ` Ivaylo Dimitrov
2020-11-27 17:30 ` Tomi Valkeinen
2020-11-27 18:44 ` Ivaylo Dimitrov [this message]
2020-11-25 9:07 ` Daniel Vetter
2020-11-27 8:43 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23e27b7a-d2b9-a0c0-7518-bb5105306a97@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®