mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] omapdrm/N900 display broken
Date: Fri, 27 Nov 2020 10:43:28 +0200	[thread overview]
Message-ID: <6f7e2f5c-3e88-25c1-d46a-8c52c15527ce@ti.com> (raw)
In-Reply-To: <CAKMK7uEAaNhr__aYxWpNmUb1jTruf0FMoPwgn8_so9mGV=yAOQ@mail.gmail.com>

On 25/11/2020 11:07, Daniel Vetter wrote:

>> Laurent, does this ring any bells? The WARN comes in drm_atomic_bridge_chain_enable() when
>> drm_atomic_get_old_bridge_state() returns null for (presumably) sdi bridge.
>>
>> I'm not sure why the bridge state would not be there.
> 
> Lack of state on first modeset usually means your
> drm_mode_config_reset didn't create one. Or whatever it is you're
> using. I didn't look whether you're wiring this up correctly or not.
> We might even want to add a ->reset function to
> drm_private_state_funcs to make this work for everyone.

The bridge driver set atomic_enable and atomic_disable, but no other atomic funcs. It was supposed
to set the legacy enable & disable.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

      reply	other threads:[~2020-11-27  8:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 18:14 Aaro Koskinen
2020-08-04 12:13 ` Tomi Valkeinen
2020-08-04 12:39   ` Tomi Valkeinen
2020-08-23 16:26     ` Aaro Koskinen
2020-08-25 13:16       ` Tomi Valkeinen
2020-11-24 21:03         ` Ivaylo Dimitrov
2020-11-26 14:11           ` Tomi Valkeinen
2020-11-26 23:17             ` Ivaylo Dimitrov
2020-11-27 11:45               ` Tomi Valkeinen
2020-11-27 13:10                 ` Ivaylo Dimitrov
2020-11-27 15:37                   ` Ivaylo Dimitrov
2020-11-27 17:30                     ` Tomi Valkeinen
2020-11-27 18:44                       ` Ivaylo Dimitrov
2020-11-25  9:07         ` Daniel Vetter
2020-11-27  8:43           ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f7e2f5c-3e88-25c1-d46a-8c52c15527ce@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®