mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Deming Wang <wangdeming@inspur.com>, miklos@szeredi.hu, corbet@lwn.net
Cc: linux-unionfs@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: docs: Modify the section of User xattr
Date: Sat, 25 Jun 2022 08:15:43 +0700	[thread overview]
Message-ID: <241393bf-1fd3-ab25-867b-7132d7590aa8@gmail.com> (raw)
In-Reply-To: <20220624014605.2007-1-wangdeming@inspur.com>

On 6/24/22 08:46, Deming Wang wrote:
> Delete duplicate words of "the".
> 

I think "Modify something" isn't clear subject, because reviewers
don't know at glance the logical change this patch is doing other
than actually reading the diff below.

For the patch message, what about "Remove duplicate the"?

In this case of trivial patch, it's OK to have the patch message
same as the subject, if the message can't be described more
concise but clearer.

> @@ -607,7 +607,7 @@ can be removed.
>  User xattr
>  ----------
>  
> -The the "-o userxattr" mount option forces overlayfs to use the
> +The "-o userxattr" mount option forces overlayfs to use the
>  "user.overlay." xattr namespace instead of "trusted.overlay.".  This is
>  useful for unprivileged mounting of overlayfs.
>  

The diff looks OK.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

      parent reply	other threads:[~2022-06-25  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  1:46 Deming Wang
2022-06-24 19:11 ` Jonathan Corbet
2022-06-25  1:15 ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=241393bf-1fd3-ab25-867b-7132d7590aa8@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=wangdeming@inspur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®