From: Keith Owens <kaos@sgi.com>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
sekharan@us.ibm.com, linux-kernel@vger.kernel.org,
lse-tech@lists.sourceforge.net, paulmck@us.ibm.com,
greg@kroah.com, Douglas_Warzecha@dell.com,
Abhay_Salunke@dell.com, achim_leubner@adaptec.com,
dmp@davidmpye.dyndns.org
Subject: Re: [Lse-tech] Re: [PATCH 0/7]: Fix for unsafe notifier chain
Date: Mon, 28 Nov 2005 04:39:36 +1100 [thread overview]
Message-ID: <24158.1133113176@ocs3.ocs.com.au> (raw)
In-Reply-To: Your message of "Sun, 27 Nov 2005 18:27:25 BST." <20051127172725.GJ20775@brahms.suse.de>
On Sun, 27 Nov 2005 18:27:25 +0100,
Andi Kleen <ak@suse.de> wrote:
>On Mon, Nov 28, 2005 at 02:59:05AM +1100, Keith Owens wrote:
>> On Sun, 27 Nov 2005 14:47:36 +0100,
>> Andi Kleen <ak@suse.de> wrote:
>> >akpm wrote
>> >> - Introduce a new notifier API which is wholly unlocked
>> >
>> >The old notifiers were already wholly unlocked. So it wouldn't
>> >even need any changes. Just additional locks everywhere.
>>
>> Wrong.
>
>Did you actually read what I wrote?
Of course I did. The whole point is that _ALL_ of the existing
notifier chain callback code is racy[*]. Saying that the code can be
left without any changes is simply ignoring the existing races. They
_ALL_ need to be fixed.
[*] Except for one bit of hand crafted locking in USB.
next prev parent reply other threads:[~2005-11-27 17:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 23:37 Chandra Seetharaman
2005-11-27 4:07 ` Andrew Morton
2005-11-27 13:47 ` [Lse-tech] " Andi Kleen
2005-11-27 15:59 ` Keith Owens
2005-11-27 17:27 ` Andi Kleen
2005-11-27 17:39 ` Keith Owens [this message]
2005-11-27 19:56 ` Andrew Morton
2005-11-27 22:03 ` Greg KH
2005-11-28 2:43 ` Paul E. McKenney
2005-11-28 4:57 ` Andrew Morton
2005-11-28 4:59 ` Andi Kleen
2005-11-28 5:05 ` Paul E. McKenney
2005-11-28 5:15 ` Andi Kleen
2005-11-28 8:31 ` Keith Owens
2005-11-28 12:07 ` Andi Kleen
2005-11-28 19:55 ` Paul E. McKenney
2005-12-04 16:19 ` Alan Cox
2005-12-06 23:38 ` Keith Owens
2005-12-07 2:43 ` Keith Owens
2005-11-28 1:19 ` Keith Owens
2005-11-28 18:58 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24158.1133113176@ocs3.ocs.com.au \
--to=kaos@sgi.com \
--cc=Abhay_Salunke@dell.com \
--cc=Douglas_Warzecha@dell.com \
--cc=achim_leubner@adaptec.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dmp@davidmpye.dyndns.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=paulmck@us.ibm.com \
--cc=sekharan@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome