mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
	arve@android.com, riandrews@android.com,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v5 2/2] staging: ion: create one device entry per heap
Date: Tue, 3 Oct 2017 14:42:32 -0700	[thread overview]
Message-ID: <2417c969-357f-d5d9-153a-2180d09b0dc6@redhat.com> (raw)
In-Reply-To: <20171003164849.rcdgez6lbpmq5llt@sirena.org.uk>

On 10/03/2017 09:48 AM, Mark Brown wrote:
> On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote:
> 
>> Thinking about this a bit more, I'm not 100% sure if this
>> will allow the security rules we want. Heap ids are assigned
>> dynamically and therefore so will the /dev/ionX designation.
>> From my understanding, security rules like selinux need to
>> be fully specified at boot time so I'm not sure how you would
>> be able to write rules to differentiate between /dev/ionX and
>> /dev/ionY without knowing the values at boottime.
> 
> Isn't this something that should be managable via udev rules that ensure
> stable names in the same way as for things like disks or ethernet
> controllers (even if it just ends up doing something like /dev/ion-gpu
> or whatever)?  If we're not giving it enough information to assign stable
> names where needed we probably need to fix that anyway.
> 

Android doesn't use a standard udev so we'd need something that
would work there. My understanding was that android needs everything
specified at boot unless that's changed.

There would be enough information to assign stable names
(e.g. /dev/ion-system) if we used the query ioctl to find out
what's actually available. Is just the ioctl useful though?

Thanks,
Laura

  reply	other threads:[~2017-10-03 21:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 13:20 [PATCH v5 0/2] staging: ion: get one device " Benjamin Gaignard
2017-09-27 13:20 ` [PATCH v5 1/2] staging: ion: simplify ioctl args checking function Benjamin Gaignard
2017-10-09  9:21   ` Benjamin Gaignard
2017-10-09 16:45     ` Laura Abbott
2017-09-27 13:20 ` [PATCH v5 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-10-02 18:07   ` Laura Abbott
2017-10-03 16:48     ` Mark Brown
2017-10-03 21:42       ` Laura Abbott [this message]
2017-10-03 23:08         ` Sandeep Patil
2017-10-03 23:37           ` Laura Abbott
2017-10-04 10:17           ` Mark Brown
2017-10-05 13:06             ` Benjamin Gaignard
2017-10-09 21:25               ` Laura Abbott
2017-10-09 22:08                 ` Mark Brown
2017-10-10  0:10                   ` Laura Abbott
2017-10-10  9:11                     ` Mark Brown
2017-10-16 22:09                       ` Laura Abbott
2017-10-17 12:39                         ` Benjamin Gaignard
2017-10-18 20:07   ` Laura Abbott
2017-10-23 15:19     ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2417c969-357f-d5d9-153a-2180d09b0dc6@redhat.com \
    --to=labbott@redhat.com \
    --cc=arve@android.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®