mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Sandeep Patil <sspatil@google.com>
Cc: Laura Abbott <labbott@redhat.com>,
	devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	arve@android.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, riandrews@android.com,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	linux-api@vger.kernel.org, sumit.semwal@linaro.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH v5 2/2] staging: ion: create one device entry per heap
Date: Wed, 4 Oct 2017 11:17:20 +0100	[thread overview]
Message-ID: <20171004101720.ob5f467tro7agpcz@sirena.co.uk> (raw)
In-Reply-To: <20171003230830.GA132839@sspatil-desktop.mtv.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote:

> It is entirely possible and easy in android/ueventd to create those nodes
> under "/dev/ion/".  (assuming the heap 'subsystem' for these new devices will
> point to 'ion').

The reason I didn't say /dev/ion/foo initially is that if people want to
keep the existing /dev/ion around for compatibility reasons then the
/dev/ion name isn't available which might cause issues.  Otherwise just
dumping everything under a directory (perhaps with a different name) was
my first thought as well.

> (Also FWIW, the SELinux permissions are also possible with the current ion
> implementation by adding rules to disallow specific ioctls instead of adding
> permissions to access device node as this change would do)

AIUI the request is to limit access to specific heaps, and obviously not
everyone wants to deal with SELinux at all.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2017-10-04 10:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 13:20 [PATCH v5 0/2] staging: ion: get one device " Benjamin Gaignard
2017-09-27 13:20 ` [PATCH v5 1/2] staging: ion: simplify ioctl args checking function Benjamin Gaignard
2017-10-09  9:21   ` Benjamin Gaignard
2017-10-09 16:45     ` Laura Abbott
2017-09-27 13:20 ` [PATCH v5 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-10-02 18:07   ` Laura Abbott
2017-10-03 16:48     ` Mark Brown
2017-10-03 21:42       ` Laura Abbott
2017-10-03 23:08         ` Sandeep Patil
2017-10-03 23:37           ` Laura Abbott
2017-10-04 10:17           ` Mark Brown [this message]
2017-10-05 13:06             ` Benjamin Gaignard
2017-10-09 21:25               ` Laura Abbott
2017-10-09 22:08                 ` Mark Brown
2017-10-10  0:10                   ` Laura Abbott
2017-10-10  9:11                     ` Mark Brown
2017-10-16 22:09                       ` Laura Abbott
2017-10-17 12:39                         ` Benjamin Gaignard
2017-10-18 20:07   ` Laura Abbott
2017-10-23 15:19     ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004101720.ob5f467tro7agpcz@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=arve@android.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=labbott@redhat.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=sspatil@google.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®